1124598 - [Task Manager] No small icon in the card view of a web page which is opened from Rocketbar visited history

Status: VERIFIED INVALID

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Hermes Cheng (inactive after July 27, 2015)]

*Description
If I open a visited website from Rocketbar search results, its card view does not contain a small icon.

*Steps:
1. visit a youtube via Browser, and then close this browser from Task Manager
2. Launch Rocketbar, and type "youtube"
3. tap the history result (visited at step 1)
4. long tap home button to enter card view

*Expected result:
The card view has a small icon.

*Actual result:
The card view does not have a small icon

*Link: https://www.youtube.com/watch?v=5hCkKaHy5VY

*Env:
Build ID               20150121002607
Gaia Revision          e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gaia Date              2015-01-21 00:25:40
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/75a462a58d7a
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150121.040751
Firmware Date          Wed Jan 21 04:08:02 EST 2015
Bootloader             L1TC000118D0

Comment 1

[Hermes Cheng (inactive after July 27, 2015)]

Attachment: logcat.txt

Comment 2

[Ben Francis [:benfrancis]]

Does this happen for all pages all the time or only occasionally

Comment 3

[Sam Foster [:sfoster] (he/him)]

We're ending up with url("http://m.youtube.com/shared/elements/gaia_grid/images/default_icon.png"); for the icon in card view, which is using the defaultIcon property of the GridItem. 

The card has an iconValue property which is populated via getIconURIForApp at https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/cards_helper.js#L21 .. in this case it is using the AppWindow instance's 'icon' property which is "/shared/elements/gaia_grid/images/default_icon.png", and prepending the app's origin. 
Does the defaultIcon need to include the correct hostname maybe? Its not safe to assume here that a relative path is relative to the system app host.

Comment 4

[Hermes Cheng (inactive after July 27, 2015)]

(In reply to Ben Francis [:benfrancis] from comment #2)
> Does this happen for all pages all the time or only occasionally

I have tried some different websites[1], and it always happened.
But, if I triggered the rocketbar from browser start page, this problem does not occur.

[1] website: Google search, Youtube, Yahoo news US, Yahoo bid Taiwan, Amazon

Comment 5

[Sam Foster [:sfoster] (he/him)]

(In reply to Sam Foster [:sfoster] from comment #3)
> We're ending up with
> url("http://m.youtube.com/shared/elements/gaia_grid/images/default_icon.
> png"); for the icon in card view, which is using the defaultIcon property of
> the GridItem. 
> 
> The card has an iconValue property which is populated via getIconURIForApp
> at
> https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/cards_helper.
> js#L21 .. in this case it is using the AppWindow instance's 'icon' property
> which is "/shared/elements/gaia_grid/images/default_icon.png", and
> prepending the app's origin. 

If we cant get the page's favicon - we should be showing the default browser icon there. IIRC to trigger this we need *no* iconValue as the stylesheet will supply it. But CardHelper currently has no way of knowing that /shared/elements/gaia_grid/images/default_icon.png is just a default... 

> Does the defaultIcon need to include the correct hostname maybe? Its not
> safe to assume here that a relative path is relative to the system app host.

Comment 6

[Sam Foster [:sfoster] (he/him)]

I can no longer reproduce this, I get the expected browser icon with all variations of the STR I have tried. Can we check its still an issue?

Comment 7

[Hermes Cheng (inactive after July 27, 2015)]

I cannot reproduce this, too. Marked it as invalid for now.

Comment 8

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Sam Foster [:sfoster] from comment #6)
> I can no longer reproduce this, I get the expected browser icon with all
> variations of the STR I have tried. Can we check its still an issue?

I was able to reproduce this issue on the reported build, but not on today's build either.

Comment 9

[Hermes Cheng (inactive after July 27, 2015)]

close this bug.