1124603 - MOZ_ASSERT(state == NotStarted) in js::GCParallelTask::startWithLockHeld()

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jean-Yves Avenard [:jya]]

Attachment: backtrace.txt

Fresh Nightly in debug mode.

Getting assert in js::GCParallelTask::startWithLockHeld()

HelperThreads.cpp:747

Has happened twice so far..

Comment 1

[Jan de Mooij [:jandem]]

Probably a dupe of bug 1124468.

Comment 2

[Jean-Yves Avenard [:jya]]

I managed to reproduce it quite consistently by doing the following:

./mach mochitest-plain dom/media/test/test_eme_playback.html

let the test complete and pass.
Attach the debugger.

Go into Preferences -> Advanced -> Network -> Click on Clear Now twice rapidly.

Comment 3

[Jon Coppeard (:jonco)]

(In reply to Jean-Yves Avenard [:jya] from comment #2)
Thanks for reporting this!

How many CPU cores do you have BTW?

Comment 4

[Jon Coppeard (:jonco)]

Attachment: bug1124603-parallel-state

Ugh, this was dumb of me :)

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 8553165 [details] [diff] [review]
bug1124603-parallel-state

Review of attachment 8553165 [details] [diff] [review]:
-----------------------------------------------------------------

Gah, I totally should have caught that in review, too.

Comment 6

[Jean-Yves Avenard [:jya]]

(In reply to Jon Coppeard (:jonco) from comment #3)
> (In reply to Jean-Yves Avenard [:jya] from comment #2)
> Thanks for reporting this!
> 
> How many CPU cores do you have BTW?

8

Comment 7

[Jon Coppeard (:jonco)]

(In reply to Jean-Yves Avenard [:jya] from comment #6)

Definitely this issue then.  Cheers!

Comment 8

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4a464da4b43

Comment 9

[Jean-Yves Avenard [:jya]]

I've been running with the patch all day, and the issue has been resolved

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f4a464da4b43