Finish up support for vertical writing modes in fieldset

RESOLVED FIXED in Firefox 38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smontagu, Assigned: smontagu)

Tracking

unspecified
mozilla38
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(3 attachments)

Follow up to bug 1123133 to add support for the new logical methods from bug 1079154 and anything else which needs updating.
Because bug 1079154 seems to be at risk, let's do this in two parts. This is another thing I had in my patch for nsFieldSetFrame, which I forgot to mention  in bug 1123133 comment 6.
Attachment #8553059 - Flags: review?(jfkthame)
And here's the second part, using the new stuff from bug 1079154. Holding off on review request until we know if bug 1079154 is going to stick.
Comment on attachment 8553059 [details] [diff] [review]
Patch 1: use min/max BSize instead of Height

Review of attachment 8553059 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this looks right, thanks.
Attachment #8553059 - Flags: review?(jfkthame) → review+
A couple of reftests that fail before patch 1 and passe after it.
Attachment #8553077 - Flags: review?(jfkthame)
Comment on attachment 8553077 [details] [diff] [review]
Reftests for patch 1

Review of attachment 8553077 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Would you mind adding something like "fieldset-height" to the filenames, just to make it easier to keep track of what the tests are about? (I know not all the existing tests do this, but I'd like to nudge us in that direction.)
Attachment #8553077 - Flags: review?(jfkthame) → review+
Checked in patch 1 and the associated reftests patch, with the naming change requested in comment 5

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac8525492f27
https://hg.mozilla.org/integration/mozilla-inbound/rev/88f31158c825
Flags: in-testsuite?
Whiteboard: [leave open]
Comment on attachment 8553060 [details] [diff] [review]
Patch 2: use logical ReflowChild, FinishReflowChild and ApplyRelativePositioning

We can push ahead with this now and close this bug.
Attachment #8553060 - Flags: review?(jfkthame)
Attachment #8553060 - Flags: review?(jfkthame) → review+
https://hg.mozilla.org/mozilla-central/rev/70dda75a914f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1134534
You need to log in before you can comment on or make changes to this bug.