Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Excessive drop-downs and other widths in Lightning's options - Calendar pane tabs

RESOLVED FIXED in 4.0.0.1

Status

Calendar
Preferences
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ton, Assigned: Paenglab)

Tracking

Lightning 3.9
4.0.0.1
x86
Windows 7

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8553061 [details]
long calendar dropdowns.png

As the screenshots display, some tabs in TB option's Calendar pane - especially the Gereral tab's drop-down menus and to a lesser extent the Categories tab's color picker - take the full width of the options window, while there is no need to, uglifying the UI.

This behaviour may very well be caused by TB itself (or a combination) as some other TB options take up lots of horizontal space and some buttons appear to "get pulled to the right side", though that never results in huge drop-downs like in the Calendar pane view. In other words: I'm afraid this may also happen for other extensions besides Calendar. It should be possible however to have smaller drop-downs and maybe a smaller color picker,like in some other pane/tab views.

Using latest TB and Lightning Aurora nightlies, but the problem exists for a long time. Screenshots were taken for the nl locale but the issue is also valid in others, including en-US.
(Reporter)

Updated

3 years ago
Summary: Excessive drop-downs and other widths in Lightning's Calendar pane tabs → Excessive drop-downs and other widths in Lightning's options - Calendar pane tabs

Comment 1

3 years ago
The TB (and therby also the Lightning) prefs are getting actually are currently moving to be displayed in a tab. See bug 925746. So, please recheck with mail.preferences.inContent enabled in the config editor of a current Daily.
(Reporter)

Comment 2

3 years ago
Created attachment 8554151 [details]
long calendar dropdown_incontents.png

(In reply to MakeMyDay from comment #1)

Thanks for notifying.

However, and as expected, the problem also exists in the tab view, as the screenshot shows. Therefore and considering this ‘uglification’ being in TB for quite a while now, as well as the tab view probably being made public (to the final version) a long while from now, I’d say this should be fixed prior to that.

I’bve never understood why options in a tab view needed to be implemented in FF in the first place (and now TB) and thought it was meant for developers only in order to access the options more often, as opposed to regular users, but that’s another story.

Comment 3

3 years ago
Prefs in a Tab is planned to be the way to access prefs in the next major version of Thunderbird (Tb 38), so probably there will ne no changes for the current dialog only I guess.

Richard, is this something to consider for the new prefs?
Flags: needinfo?(richard.marti)
(Assignee)

Comment 4

3 years ago
The Timezone menulist is to wide. Also the "Default Values for New Items" are looking to wide when Events is selected. When Tasks is selected it looks also weird  with menulists somewhere in the middle of the line. Maybe the items which are now hidden should be disabled instead to be always visible.

On Reminders tab the Play a sound part with the three buttons below could be arranged like the Homepage part on Firefox: attachment 8439538 [details].

I will try to do a proposal.

The other thing are looking like on Firefox and Thunderbird.
Flags: needinfo?(richard.marti)
(Assignee)

Comment 5

3 years ago
Created attachment 8554256 [details]
redesign.png

Philipp, what do you think about this proposal?

- The timezone menulist has only the length of the longest entry.
- The Event/Task menulist in "Default Values for New Items" is now on the left and the correlating settings are on the right and not always using the whole width.
- The "Play a sound" combo has the three buttons stretched like the Firefox attachment i added in previous comment.

This screenshot is from the dialog prefs to show how it's looking with lesser space and in German to show with longer labels. If needed I can attach the in-content screenshot but it's looking almost the same as the same files are used.
Attachment #8554256 - Flags: feedback?(philipp)
Comment on attachment 8554256 [details]
redesign.png

LGTM, f=philipp
Attachment #8554256 - Flags: feedback?(philipp) → feedback+
(Assignee)

Comment 7

3 years ago
Created attachment 8554279 [details] [diff] [review]
Bug1124640.patch
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8554279 - Flags: review?(philipp)
Comment on attachment 8554279 [details] [diff] [review]
Bug1124640.patch

Review of attachment 8554279 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp with the following change:

::: calendar/base/content/preferences/alarms.xul
@@ +62,5 @@
>          </preferences>
>  
>          <groupbox>
>              <caption label="&pref.alarmgoesoff.label;"/>
> +            <grid>

Can you give these elements sensible ids while you are here? Something like this:

alarm-sound-grid
alarm-sound-columns
alarm-sound-label-column
alarm-sound-content-column
alarm-sound-rows
alarm-sound-soundfile-row
...

Similar for the other elements you've changed.
Attachment #8554279 - Flags: review?(philipp) → review+
(Assignee)

Comment 9

3 years ago
Created attachment 8554308 [details] [diff] [review]
Bug1124640.patch

Added the IDs.
Attachment #8554279 - Attachment is obsolete: true
Attachment #8554308 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
Pushed to comm-central changeset 1e53e59b569a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.0
(Reporter)

Comment 11

3 years ago
Thanks for the efforts to fix this. Will the categories view remain as it is? Wouldn't a width of what’s used in the Views tab (or General, Tasks selected) be enough?

(In reply to Richard Marti (:Paenglab) from comment #4)
> 
> On Reminders tab the Play a sound part with the three buttons below could be
> arranged like the Homepage part on Firefox: attachment 8439538 [details].

For some reason I never experienced an issue with those 3 buttons being too narrow in both FF and TB Aurora or release. Apparently this is going to change, and to be honest I'm afraid users will complain about them being too wide when that lands. But I rely on the fact you know what you are doing - making it consistent with FF is good anyway.
(Assignee)

Comment 12

3 years ago
(In reply to Ton from comment #11)
> Thanks for the efforts to fix this. Will the categories view remain as it
> is? Wouldn't a width of what’s used in the Views tab (or General, Tasks
> selected) be enough?

It stays like it is. In FX the Applications list and in TB the Attachments list are also the whole width.

> (In reply to Richard Marti (:Paenglab) from comment #4)
> > 
> > On Reminders tab the Play a sound part with the three buttons below could be
> > arranged like the Homepage part on Firefox: attachment 8439538 [details].
> 
> For some reason I never experienced an issue with those 3 buttons being too
> narrow in both FF and TB Aurora or release. Apparently this is going to
> change, and to be honest I'm afraid users will complain about them being too
> wide when that lands. But I rely on the fact you know what you are doing -
> making it consistent with FF is good anyway.

This styling is not yet in FX but soon: bug 1038291
(Reporter)

Comment 13

3 years ago
(In reply to Richard Marti (:Paenglab) from comment #12)
> 
> It stays like it is. In FX the Applications list and in TB the Attachments
> list are also the whole width.

So I noticed and compared the view with them, but these lists exist to list two text colums that need the width for obvious reasons. The Categories view needs room for variable but commonly short labels (note the width of the Add/Edit panes btw) and the colors themselves could even be square blocks, though I presume they are rectangles to indicate that they fill up entire lines. But it's fine by me.

> This styling is not yet in FX but soon: bug 1038291

Thanks.
You need to log in before you can comment on or make changes to this bug.