1124660 - Settings app is truncated when accessed via rocketbar "no internet connection"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: 2015-01-22-09-03-31.png

+++ This bug was initially created as a clone of Bug #1124216 +++

STR, on a Flame-kk device running 2.1.
1. Ensure wi-fi and cell connections are disabled
2. Tap on the rocket bar and start entering a URL in the URL bar
3. Directly under the URL bar you should get a little settings icon with the message "No internet connection"
4. Tap on the settings icon. This should open a settings screen with just the "network & connectivity" items.
5. Select "Wi-Fi"
6. Turn on the Wi-Fi toggle and to expose the advanced settings, and then click on "Manage networks"
7. Click on "Join Hidden Network"
8. On the screen to add a hidden network, there is a dropdown menu under "Security". Click on it

Expected:
The dialog is not truncated

Actual:
The dialog is truncated (see screenshot)

In fact if you have enough wifi networks nearby you can see this on step 6 after turning on the wifi toggle as the bottom button on the screen ("manage certificates") is cut off as well.

This bug appears to only affect 2.1.

[Blocking Requested - why for this release]: regression in 2.1

Comment 1

[howie [:howie]]

Triage: regression , blocking, can we find which patch in 2.2 has fixed this issue?

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I found both the window of commits in central that fixed this issue as well as the window that originally caused it in 2.1 because I, at first, thought I could not reproduce it in central.  I'm posting both of those windows here in the hopes that they will help point to the correct fix.

Note: We do not have access to the fx-team branch in order to narrow down further for the fixed window.

Central Fixed Window:

Last Broken 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141106040023
Gaia: 068b9711277b06c7d633517f9e1fcb5624bb39b3
Gecko: a074c0112919
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Working 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141106040623
Gaia: 068b9711277b06c7d633517f9e1fcb5624bb39b3
Gecko: 41adad987d82
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Last Broken gaia / First Working gecko - Issue is fixed
Gaia: 068b9711277b06c7d633517f9e1fcb5624bb39b3
Gecko: 41adad987d82

First Working gaia / Last Broken gecko - Issue is NOT fixed
Gaia: 068b9711277b06c7d633517f9e1fcb5624bb39b3
Gecko: a074c0112919

Gecko Pushlog:  http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a074c0112919&tochange=41adad987d82



B2g34 2.1 Regression Window:

Last Working 
Environmental Variables:
Device: Flame 2.1
BuildID: 20141105060632
Gaia: db7cf6079a8aec728c463151fc57d65ae946ebe4
Gecko: f7aaf344a3c8
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken 
Environmental Variables:
Device: Flame 2.1
BuildID: 20141105063632
Gaia: 445656e36d14054d46a8f201dc68d76da8cfa281
Gecko: e7efb38a6477
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: db7cf6079a8aec728c463151fc57d65ae946ebe4
Gecko: e7efb38a6477

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: 445656e36d14054d46a8f201dc68d76da8cfa281
Gecko: f7aaf344a3c8

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/db7cf6079a8aec728c463151fc57d65ae946ebe4...445656e36d14054d46a8f201dc68d76da8cfa281

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Kevin, can you take a look at this please? This might have been caused by the work done on Bug 1088352.

This was fixed in 2.2 but we can''t narrow the fix window down any further since we cannot access the fx-team branch.

Comment 4

[Kevin Grandon :kgrandon]

(In reply to KTucker [:KTucker] from comment #3)
> This was fixed in 2.2 but we can''t narrow the fix window down any further
> since we cannot access the fx-team branch.

Sounds like we may just want to do a gaia-only reverse bisection to find out what fixed this?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Could you help to find out what's fixing this and uplift?

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

The difference between master is, system launch app window for settings app but activity window on master.
bug 1007600 would fix it, but I think it might be risky to uplift it.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to George Duan [:gduan] [:喬智] from comment #6)
> The difference between master is, system launch app window for settings app
> but activity window on master.
> bug 1007600 would fix it, but I think it might be risky to uplift it.

Good investigation and let's not uplift bug 1007600 but check for inline activity before adjusting height.

Comment 8

[GitHub Autolander Bot]

Attachment: [PullReq] cctuan:1124660 to mozilla-b2g:v2.1

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

Hi Alive,
could I have your review on this patch? Thanks.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8558452 [details] [review]
PR to 2.1

Thanks!

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8558452 [details] [review]
PR to 2.1

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Not a regression nor feature.
[User impact] if declined: User might see a truncated settings page if launch settings from search app, see attachment 8553082 [details]
[Testing completed]:
yes, manual test is ok, and also add unit test
[Risk to taking this patch] (and alternatives if risky):
There might be risky if we launch activity window (triggered by window type instead of inline type) from search app. However, there are only two kinda activities, one is settings and another is market place, and I've check market place , it works just fine.
[String changes made]:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/35ec089b1e8ce1b490de1e32183e7872b22ab4ec

Comment 13

[yong.ren]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #12)
> v2.1:
> https://github.com/mozilla-b2g/gaia/commit/
> 35ec089b1e8ce1b490de1e32183e7872b22ab4ec

Hi Ryan:

   please porting this modify to v2.1s, thanks

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Vincent is handling the 2.1s branch.

Comment 15

[yong.ren]

Hi vance:

   As comment 14, please communicate with vincent to uplift this modified to 2.1s branch, thanks .

Comment 16

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Steven, could you help to make sure this one land on 2.1s

Thanks

Comment 17

[Steven Yang [:styang]]

Vincent, please put it into your queue for uplifting. thanks.

Comment 18

[Vincent Liu[:vliu]]

(In reply to Steven Yang [:styang] from comment #17)
> Vincent, please put it into your queue for uplifting. thanks.

Clear the ni? since the code has been merged.

Comment 19

[helen（leave from Mozilla）]

Attachment: v2.1.mp4

This bug has been verified as pass on latest build of Flame v2.1 & v2.1s_512mb by the STR in Comment 0. 

Results:
Settings app is not truncated when accessed via rocketbar "no internet connection".

See attachment: v2.1.mp4
Reproduce rate: 0/10

Device: Flame v2.1(Pass)
Build ID               20150603161201
Gaia Revision          2304a1f6327c2ccf35d6995ee16f2231ed1f22a3
Gaia Date              2015-05-26 13:30:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/4219ad1958a3
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.193342
Firmware Date          Wed Jun  3 19:33:55 EDT 2015
Bootloader             L1TC000118D0


Device: v2.1s_512mb(Pass)
Build ID               20150603001202
Gaia Revision          e29043077da834854bfda9d409d1e690fb8070c3
Gaia Date              2015-06-01 10:35:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/5685467cbdb5
Gecko Version          34.0
Device Name            scx15_sp7715ea
Firmware(Release)      4.4.2
Firmware(Incremental)  122
Firmware Date          Thu Feb  5 12:42:58 CST 2015