1124676 - [Desktop] Cannot cancel the payment from confirmation page

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Victor Carciu]

Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0

Steps to reproduce:
1.Open marketplace STAGE , login and search for a paid app
2.Enter pin , then press Cancel from payment confirmation page

Expected results:
Confirm payment popup is closed and Payment Cancelled message is displayed at the bottom of of the page

Actual results:
Payment cancelled message is displayed on the desktop popup , together with a waiting spinning wheel. The popup is never closed.

Please see screencast for this bug : http://screencast.com/t/NpUJVNNg

Comment 1

[Stuart Colville [:muffinresearch]]

So seeing this makes me think that we need openers to poll for the close on the window.

We do this fancy postMessage thing from payments to tell the opener to close the window but if the popup's location has changed this won't help much as there's no postMessaging going to come from other people's domains e.g. the payment provider or identity.

Comment 2

[Stuart Colville [:muffinresearch]]

Comment 1 is really a different so I'm going to file a new bug for that.

Comment 3

[Stuart Colville [:muffinresearch]]

This bug requires us to add code to close the window in the pages that we get to after redirection from the provider.

Comment 4

[Stuart Colville [:muffinresearch]]

PR https://github.com/mozilla/webpay/pull/588

Comment 5

[Stuart Colville [:muffinresearch]]

With further investigation it seems we were hitting an old code path which caused us to render a non-spartacus view which doesn't have the right polyfills for mozpaymentprovider.

https://github.com/mozilla/webpay/blob/master/webpay/bango/views.py#L128

Comment 6

[Stuart Colville [:muffinresearch]]

Webpay patch landed. Just need to test this and see if that fixes cancellation as expected.

https://github.com/mozilla/webpay/commit/47b3489d106a463fe13398d32dcba14d75092556

Comment 7

[Stuart Colville [:muffinresearch]]

Needs pushing to stage before this can be verified.