add MOZ_OVERRIDE to timeline code

RESOLVED FIXED in Firefox 38

Status

DevTools
Performance Tools (Profiler/Timeline)
RESOLVED FIXED
4 years ago
a month ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

Trunk
Firefox 38
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Subclasses of TimelineMarker override some methods;
it is good to use MOZ_OVERRIDE in these cases to prevent
future errors.
(Assignee)

Comment 1

4 years ago
Created attachment 8553112 [details] [diff] [review]
add MOZ_OVERRIDE in subclasses of TimelineMarker
(Assignee)

Updated

4 years ago
Attachment #8553112 - Flags: review?(bugs)
Comment on attachment 8553112 [details] [diff] [review]
add MOZ_OVERRIDE in subclasses of TimelineMarker

rs+
Attachment #8553112 - Flags: review?(bugs) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/eb58e77e2a77
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/eb58e77e2a77
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)

Updated

a month ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.