Closed Bug 1124700 Opened 11 years ago Closed 11 years ago

[Desktop]Scrollbar is missing in Terms and Conditions page

Categories

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Product:
Marketplace Graveyard
Component:
Payments/Refunds
Version:
Avenir
Platform:
x86_64
Windows 7
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2015-01-27

People

(Reporter: vcarciu, Assigned: muffinresearch)

References

Details

Prerequisites: Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 Steps to reproduce: 1.Open marketplace STAGE , login and search for a paid app 2.Enter pin , then press Terms & Conditions link from payment confirmation page Expected results: A scrollbar is needed in order to be able to scroll down in the popup to see all text Actual results: Scrollbar is missing and users are not able to read terms and conditions Please see screencast for this bug : http://screencast.com/t/6dcKb9X1t9P
Will be interesting to see if the change to the single popup code affects this. The new code (only on -dev at time of writing this comment) allows scrollbars https://github.com/mozilla/marketplace-core-modules/blob/master/utils.js#L208 Whereas the opener in fxpay.utils doesn't. If that works (we'll try and get that code on stage soon) then we'll just need to tweak fxpay for where the windown opening is happening from that util when used outside marketplace. As it's a trivial change I'll prepare a patch for that.
Ah actually thinking about it we're probably be using the fxpay opener when already logged-in so we'll need to bear that in mind when testing this theory.
https://github.com/mozilla/fxpay/pull/64
Assignee: nobody → scolville
Status: NEW → ASSIGNED
Checked the theory out and it worked. Just need to bump the fxpay version on fireplace for this to be fixed.
Priority: -- → P3
PR: https://github.com/mozilla/fireplace/pull/936 Tests failing due to circular deps by the looks of it.
Verified as fixed : http://screencast.com/t/TpvwaQQ6j
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.