1124714 - signaling_unittests bug - it includes PeerConnectionImplEnumsBinding

Status: RESOLVED WONTFIX

(Core :: WebRTC, defect)

Description

[Tomasz Bujlow]

Attachment: build.log

This bug happens after including "nsGlobalWindow.h".

This is a C++ bug.  signaling_unittests.cpp is doing this: 

   #include "PeerConnectionImplEnumsBinding.cpp" 

And it's doing this in an environment in which certain #defines are set 
in such a way that the string classes used are not the normal ones used 
by bindings.  This happens to work completely by accident because 
PeerConnectionImplEnumsBinding.cpp doesn't #include anything that 
involves strings too much, but including nsGlobalWindow.h in 
PeerConnectionImplEnumsBinding.cpp includes some string stuff and the 
world blows up.

I am attaching the build.log.

General steps to reproduce:

1. Edit mozilla-central/dom/bindings/Codegen.py and add:

---------------------------------------------------------------
bindingHeaders["nsGlobalWindow.h"] = True
---------------------------------------------------------------

in "class CGBindingRoot(CGThing):" just after:

---------------------------------------------------------------
bindingHeaders["xpcpublic.h"] = dictionaries ## xpc::UnprivilegedJunkScope
---------------------------------------------------------------

2. Edit mozilla-central/dom/base/moz.build and add:

---------------------------------------------------------------
'nsGlobalWindow.h',
---------------------------------------------------------------

in the following section:

---------------------------------------------------------------
EXPORTS += [
---------------------------------------------------------------

3. Try to compile Firefox.

Comment 1

[Maire Reavy [:mreavy]]

We don't support the configuration you're trying to use.  If you want to contribute a patch, we'll consider/review it for Firefox