Closed Bug 1124753 Opened 5 years ago Closed 5 years ago

timeline does not need MOZ_ENABLE_PROFILER_SPS

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: tromey, Assigned: tromey)

Details

Attachments

(1 file)

The timeline features in docshell were gated on MOZ_ENABLE_PROFILER_SPS,
but since the introduction of the TimelineMarker class, I think this has not
been needed.
Comment on attachment 8553207 [details] [diff] [review]
timeline doesn't need MOZ_ENABLE_PROFILER_SPS

Another fairly simple one.
Attachment #8553207 - Flags: review?(bugs)
Comment on attachment 8553207 [details] [diff] [review]
timeline doesn't need MOZ_ENABLE_PROFILER_SPS

r+ assuming this builds everywhere ;)
Attachment #8553207 - Flags: review?(bugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fd6d5d02cdec
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline).

dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.