Closed
Bug 1124753
Opened 9 years ago
Closed 9 years ago
timeline does not need MOZ_ENABLE_PROFILER_SPS
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: tromey, Assigned: tromey)
Details
Attachments
(1 file)
|
3.72 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
The timeline features in docshell were gated on MOZ_ENABLE_PROFILER_SPS, but since the introduction of the TimelineMarker class, I think this has not been needed.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=22432adc9031
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8553207 [details] [diff] [review] timeline doesn't need MOZ_ENABLE_PROFILER_SPS Another fairly simple one.
Attachment #8553207 -
Flags: review?(bugs)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8553207 [details] [diff] [review] timeline doesn't need MOZ_ENABLE_PROFILER_SPS r+ assuming this builds everywhere ;)
Attachment #8553207 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fd6d5d02cdec
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd6d5d02cdec
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
|
||
Comment 7•9 years ago
|
||
Sorry for the spam. Moving bugs to Firefox :: Developer Tools: Performance Tools (Profiler/Timeline). dkl
Component: Developer Tools: Timeline → Developer Tools: Performance Tools (Profiler/Timeline)
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•