Closed Bug 1124767 Opened 6 years ago Closed 6 years ago

FlameGraph._drawTicks can be very very slow when completely zoomed in

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: vporof, Assigned: vporof)

References

Details

Attachments

(2 files)

Attached file profile.json
For long recordings, drawing ticks is super slow.

Attached is a profile made with the new perf tool showing that we spend 50% of our time just in that function.
Attached patch v1Splinter Review
Turns out that when we were super zoomed in, we were drawing lines form -a bazillion pixels to +a bazillion pixels. Needless to say, that's close to almost 2xbazillion more lines that we need.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8553242 - Flags: review?(jsantell)
Comment on attachment 8553242 [details] [diff] [review]
v1

Review of attachment 8553242 [details] [diff] [review]:
-----------------------------------------------------------------

hopefully this improves performance to get the sweet spot of less than big O bazillian
Attachment #8553242 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/aaa2586234e3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.