net/HttpBaseChannel.h:193:14: warning: 'GetProxyURI' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

RESOLVED FIXED in mozilla38

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla38
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Build warning with clang 3.6:
{
 1:23.90 In file included from /scratch/work/builds/mozilla-central/mozilla-central.12-12-07.08-38/obj/netwerk/base/Unified_cpp_netwerk_base0.cpp:20:
 1:23.90 In file included from /scratch/work/builds/mozilla-central/mozilla-central.12-12-07.08-38/mozilla/netwerk/base/ChannelDiverterChild.cpp:9:
 1:23.90 In file included from ../../dist/include/mozilla/net/HttpChannelChild.h:11:
 1:23.90 Warning: -Winconsistent-missing-override in /scratch/work/builds/mozilla-central/mozilla-central.12-12-07.08-38/obj/dist/include/mozilla/net/HttpBaseChannel.h: 'GetProxyURI' overrides a member function but is not marked 'override'
 1:23.90 ../../dist/include/mozilla/net/HttpBaseChannel.h:193:14: warning: 'GetProxyURI' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
 1:23.90   NS_IMETHOD GetProxyURI(nsIURI **proxyURI);
 1:23.90              ^
 1:23.90 ../../dist/include/nsIHttpChannelInternal.h:205:14: note: overridden virtual function is here
 1:23.90   NS_IMETHOD GetProxyURI(nsIURI * *aProxyURI) = 0;
 1:23.90              ^
}

Looks like this function was just added in bug 436344. Just needs a MOZ_OVERRIDE annotation.
Posted patch fixSplinter Review
Assignee: nobody → dholbert
Attachment #8553248 - Flags: review?(mcmanus)
Comment on attachment 8553248 [details] [diff] [review]
fix

Review of attachment 8553248 [details] [diff] [review]:
-----------------------------------------------------------------

missed that - sorry, the patch had been under development for a long while. do any of the try builders enforce the override warning?
Attachment #8553248 - Flags: review?(mcmanus) → review+
Nope, clang 3.6 is still bleeding-edge enough that we don't have it on our build boxes yet.

(And we still have too many un-fixed instances of this warning to be able to build successfully with --enable-warnings-as-errors, with clang 3.6 right now, though bug 1117034 & its dependencies are rapidly addressing that.)
(Thanks for the review! I'll land this on inbound once it's open.)
https://hg.mozilla.org/mozilla-central/rev/3d49d58f7f8c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Sorry for missing this. Thanks, Daniel and Patrick.
Could it be that this fix is the reason why proxy addons such as FoxyProxy are no longer proxying according to the patterns the user configured in the addon ?
436344 will require an update to foxyproxy.. the fp devs were one of the advocates of that change so I expect it will come quickly. (impact >= 38)
You need to log in before you can comment on or make changes to this bug.