Closed
Bug 1124836
Opened 10 years ago
Closed 10 years ago
When --good is supplied with a date that is later than --bad, --find-fix should be recommended in the error message
Categories
(Testing :: mozregression, defect)
Testing
mozregression
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaws, Assigned: parkouss)
Details
Attachments
(1 file)
When --good is supplied with a date that is later than --bad, --find-fix should be recommended in the error message
Right now it just shows:
$ mozregression --bad 2015-01-06 --good 2015-01-21 --bits 32 --log-mach-verbose 0:00.00 LOG: MainThread Bisector INFO Unable to get valid builds within the given range. You should try to launch mozregression again with a larger date range.
|
Assignee | |
Comment 1•10 years ago
|
||
Yep, I think this is a nice to have. :)
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•10 years ago
|
||
Well I fixed it, and took the opportunity to refactor a bit the main.py module (reducing the complexity of the bi cli() function). Also, the module is 100% covered by unit tests now.
Attachment #8553663 -
Flags: review?(wlachance)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8553663 [details] [review]
Refactor main module
All this LGTM! Feel free to merge at your leisure.
Attachment #8553663 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
merged: https://github.com/mozilla/mozregression/commit/cc960ca0fba92295bceb0b210e910255245c4d07.
I close this bug, this is fixed in master and will be available on PyPi with the next release.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•