1124984 - symbolstore.py forced gzip call

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Todd Whiteman]

Attachment: Forced gzip command

When processing crash reports (on unix), the gzip call can stall (prompting for input) if the destination .gz file already exists.

This isn't a problem in regular Firefox builds, but I run into it when building Komodo's crash report symbols, as we use it to process python libraries (.so) files, which in some cases can occur in multiple directories.

Shouldn't be any harm in adding this gzip option for other Linux dump builders.

Comment 1

[(not currently active) Ted Mielczarek]

Comment on attachment 8553492 [details] [diff] [review]
Forced gzip command

Seems fine.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b87040211bcc

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8553492 [details] [diff] [review]
Forced gzip command

Thanks for the patch, Todd! A couple minor things for the future, though. First, please use the checkin-needed bug keyword when your patch is ready to land. Our automated bug marking tools work much better with it (the checkin? flag is more useful for multi-patch bugs where things aren't all landing at the same time).

Also, please make sure that your patches include commit information. The link below provides some instructions to ensure that your patches have the needed metadata. Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b87040211bcc