symbolstore.py forced gzip call

RESOLVED FIXED in mozilla38

Status

RESOLVED FIXED
4 years ago
9 months ago

People

(Reporter: twhitema, Assigned: twhitema)

Tracking

unspecified
mozilla38
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8553492 [details] [diff] [review]
Forced gzip command

When processing crash reports (on unix), the gzip call can stall (prompting for input) if the destination .gz file already exists.

This isn't a problem in regular Firefox builds, but I run into it when building Komodo's crash report symbols, as we use it to process python libraries (.so) files, which in some cases can occur in multiple directories.

Shouldn't be any harm in adding this gzip option for other Linux dump builders.
(Assignee)

Updated

4 years ago
Attachment #8553492 - Flags: review?(ted)
Comment on attachment 8553492 [details] [diff] [review]
Forced gzip command

Seems fine.
Attachment #8553492 - Flags: review?(ted) → review+
(Assignee)

Updated

4 years ago
Attachment #8553492 - Flags: checkin?
Attachment #8553492 - Attachment is patch: true
Comment on attachment 8553492 [details] [diff] [review]
Forced gzip command

Thanks for the patch, Todd! A couple minor things for the future, though. First, please use the checkin-needed bug keyword when your patch is ready to land. Our automated bug marking tools work much better with it (the checkin? flag is more useful for multi-patch bugs where things aren't all landing at the same time).

Also, please make sure that your patches include commit information. The link below provides some instructions to ensure that your patches have the needed metadata. Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Attachment #8553492 - Flags: checkin? → checkin+
https://hg.mozilla.org/mozilla-central/rev/b87040211bcc
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38

Updated

9 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.