1124994 - Add a 'sheriffed' alias to get all trees that sheriffs will likely care about.

Status: RESOLVED INVALID

(Developer Services :: General, task)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm working on getting a sheriffing bootstrap script set up to make getting set up for typical sheriffing tasks easier.

One thing that'd be nice to have is an alias to pull all trees that sheriffs will actually care about. The 'releases' alias gets a bunch of trees that are old or otherwise unsheriffed.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: MozReview Request: bz://1124994/KWierso

/r/2879 - Bug 1124994 - Add a 'sheriffed' alias to pull the trees that sheriffs will likely care about

Pull down this commit:

hg pull review -r 39bd59a4fb130de7c2e21f4f5676a7e66661d520

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8553521 [details]
MozReview Request: bz://1124994/KWierso

Ryan, just double-checking that these are the trees we should care about.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8553521 [details]
MozReview Request: bz://1124994/KWierso

Looks right to me.

The only question I have is the usage of "mozilla-b2g37" et al for the B2G branches. Is that aliased from somewhere else or should it be mozilla-b2g37_v2_2 and so on.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #3)
> Comment on attachment 8553521 [details]
> MozReview Request: bz://1124994/KWierso
> 
> Looks right to me.
> 
> The only question I have is the usage of "mozilla-b2g37" et al for the B2G
> branches. Is that aliased from somewhere else or should it be
> mozilla-b2g37_v2_2 and so on.

Hrm, I think it's all aliased, although I guess someone needs to add 'b2g37' to RELEASE_TREES.

Comment 5

[Monty the Python Review Bot]

https://reviewboard.mozilla.org/r/2879/#review2133

Always look on the bright side of life.

I analyzed your Python changes and found 2 errors.

The following files were examined:

  pylib/mozautomation/mozautomation/repository.py

::: pylib/mozautomation/mozautomation/repository.py
(Diff revision 1)
> +    'sheriffed': ('central', 'inbound', 'b2ginbound', 'fx-team', 'aurora',
> +        'beta', 'b2g37', 'b2g34', 'b2g32', 'b2g30', 'release', 'esr31'),

E128: continuation line under-indented for visual indent
Continuation lines indentation.

Continuation lines should align wrapped elements either vertically
using Python's implicit line joining inside parentheses, brackets
and braces, or using a hanging indent.

When using a hanging indent these considerations should be applied:
- there should be no arguments on the first line, and
- further indentation should be used to clearly distinguish itself as a
continuation line.

Okay: a = (\n)
E123: a = (\n    )

Okay: a = (\n    42)
E121: a = (\n   42)
E122: a = (\n42)
E123: a = (\n    42\n    )
E124: a = (24,\n     42\n)
E125: if (\n    b):\n    pass
E126: a = (\n        42)
E127: a = (24,\n      42)
E128: a = (24,\n    42)
E129: if (a or\n    b):\n    pass
E131: a = (\n    42\n 24)

Comment 6

[Ed Morley [:emorley]]

The 'sheriffed' alias can refer to other aliases, right?
If so, you can replace several of the entries with 'integration' - will save duplication.

Also, I think the release tree list could be pruned of out of date repos - at which point you may find it matches the list you are interested in anyway - so 'sheriffed' could just map to 'integration, release'...

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8553521 [details]
MozReview Request: bz://1124994/KWierso

https://reviewboard.mozilla.org/r/2877/#review2309

edmorley makes some good points. But those can be addressed later.

I think that if you want to maintain a list of sheriffed repos, that's totally acceptable.

Given that every person/group is different, I see this culminating with support for locally-defined repo lists in hgrc files. But that's scope bloat for this change.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Looking back at this, I don't think this really needs to land. My script is getting along just fine without the sheriffed alias, and it's not that hard to get other trees pulled in outside of the integration and release aliases.

I'm closing the bug, though I would welcome that "add repo lists to hgrc" thing gps mentioned.

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: MozReview Request: Bug 1124994 - Add a 'sheriffed' alias to pull the trees that sheriffs will likely care about