1124998 - Make improvements to the SessionStore#CloseTab API

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Session Restore, defect, P5)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Two things come to mind:
1. Convert the *CloseTab methods take an index and not a JSON data literal. This matches Desktop and makes a lot more sense.
2. Remove "old" closed tab data. Desktop removes closed tab data after a given time.

Looks like #2 is done in an Idle handler:
http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/SessionStore.jsm#1506

#2 would require changing the Fennec closedTab JSON structure a little, but it would reduce the size of the file.

Comment 1

[Jan Henning [:JanH]]

Can't say anything off-hand about #1, but the Desktop implementation for #2 now lives at https://dxr.mozilla.org/mozilla-central/rev/6be5c7d30d2def62a762ac187252eba626b23a92/browser/components/sessionstore/SessionStore.jsm#2192.

The default value on Desktop is to cleanup old "Recently closed tabs" after two weeks, so based on that even moderate usage would likely hit our current value of browser.sessionstore.max_tabs_undo first, but it might still be an interesting idea.

Comment 2

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.