1125031 - The build_stage should be final stage before packaging

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Ricky Chien [:rickychien] (inactive)]

we should make sure build_stage is in final stage before packaging / compressing application.zip into profile. At present, webapp-zip.js still try to exclude [1] some unnecessary files and adds new l10n files [2] into zip.

In bug 1043953, WebIDE is trying to read source from build_stage but it's not final stage yet.

So we should move these excluding and l10n processing out of webapp-zip to make thing easier.

[1] https://github.com/mozilla-b2g/gaia/blob/155461a49/build/webapp-zip.js#L49-L128
[2] https://github.com/mozilla-b2g/gaia/blob/155461a49/build/webapp-zip.js#L149-L172

Comment 1

[Alexandre Poirot [:ochameau]]

File exclusion is less important to fix than l10n.
If we fix l10n we could map httpd to build_stage and have same behavior than on device!
For file exclusion a simple thing we can start doing is avoid copying useless files to stage like README, package.json, .git, ... For the others may be WebIDE should accept a blacklist parameter or something.
I think it is pretty common to have build files in a stage folder.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 27703

Here is just one part to clean that up, a blacklist that is also used when creating build_stage, so that we avoid copying file to stage if not necessary.
I had to keep the same blacklist during webapp-zip as requirejs doesn't use any blacklist (yet?)

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Cool!
However, I found someone try to invoke a bunch of copyFileTo() instead of copyDirTo() to shuffle files such as apps/system/build/build.js [1] and we still have to fix them. :)


[1] https://github.com/mozilla-b2g/gaia/blob/26ff17176143e3f1494c9b63ba68d1c9b6059d01/apps/system/build/build.js#L22-L27