"Reload All Tabs" should obey browser.sessionstore.max_concurrent_tabs

NEW
Unassigned

Status

SeaMonkey
Tabbed Browser
--
enhancement
4 years ago
4 years ago

People

(Reporter: tonymec, Unassigned)

Tracking

Trunk
x86_64
Linux

SeaMonkey Tracking Flags

(seamonkey2.35 affected)

Details

Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0 SeaMonkey/2.35a1 ID:20150122003001 c-c:f4503d2596a4 m-c:34e2d2bd7ec4

I don't know if the "Right-click tab → Reload All Tabs" menuitem belongs to an extension or to vanilla SeaMonkey (the existence of bug 19587 and bug 210760 makes me believe that it could belong to SeaMonkey itself), but regardless, IMHO it ought not to reload all my 121 tabs in parallel when browser.sessionstore.max_concurrent_tabs is set to 7.

I noticed this after setting the mailer offline during startup to delay the "get mail at startup" operation after a crash. Of course most browser tabs failed to restore, so when I was ready to go back online (and had) I hit "Reload all tabs" to get them from the web. To my consternation, they all started reloading in parallel, with the result that they actually went more slowly than when only 7 at a time, with no progress indication, and many tabs (especially at Mozilla sites such as AMO and BMO) got "This document contains no data", due IIUC to a timeout.

Comment 2

4 years ago
I don't think it's wise to overload "browser.sessionstore.max_concurrent_tabs". I suggest something like "browser.tabs.reload.max_concurrent_tabs".
(In reply to Philip Chee from comment #2)
> I don't think it's wise to overload
> "browser.sessionstore.max_concurrent_tabs". I suggest something like
> "browser.tabs.reload.max_concurrent_tabs".

Well, okay. And of course positive values should mean "no more than this number (plus the current one if changed)" like it already does at startup. But what about <=0? With browser.sessionstore.max_concurrent_tabs, <0 means "all" which is the current behaviour of the "reload all tabs" function, but 0 means "only the current tab in each window" which is not very relevant for the "reload all tabs" menuitem. What about deciding that for the new pref, 0 (which could be the default unless you want the default to be -1 on the "principle of least surprise") falls back to the value and meaning of browser.sessionstore.max_concurrent_tabs? After all, IMHO it does make sense to have both (different) prefs easily set to the same value.

Comment 4

4 years ago
I think 0 doesn't make sense for something called "reload all tabs" hence <1 means all. I'm not particularly attached to this suggestion however. Could you create a new thread on mozilla.dev.apps.seamonkey about this?
(In reply to Philip Chee from comment #4)
> I think 0 doesn't make sense for something called "reload all tabs" hence <1
> means all. I'm not particularly attached to this suggestion however. Could
> you create a new thread on mozilla.dev.apps.seamonkey about this?

I'll do it, presumably in a couple of months, once I have a tolerably fast computer.
You need to log in before you can comment on or make changes to this bug.