112516 - Move some files to gfx/src/x11shared/

Status: RESOLVED WONTFIX

(Core :: XUL, enhancement)

Description

[Roland Mainz]

I'd like to move some files in from gfx/src/gtk/ to gfx/src/x11shared/

nsX11AlphaBlend.cpp
nsX11AlphaBlend.h
nsXFont.h
nsXFontAAScaledBitmap.cpp
nsXFontAAScaledBitmap.h
nsXFontNormal.cpp
nsXFontNormal.h
should be in gfx/src/x11shared/ that I can share the code in Xlib gfx code ...

Comment 1

[kill this account]

It would be good to move these files so they can be shared.

They still have a bit of a dependency on GTK.

Comment 2

[Roland Mainz]

I'll try to remove the dependicy to GDK/GTK+ code and move these parts into
gfx/src/gtk/ sources ...

Comment 3

[Roland Mainz]

Attachment: Patch for 2002-01-01-08-trunk

Note that only the gfx/src/*/Makefile.in files have been modified - all other
files have only been MOVED!!

List of files being moved to mozilla/gfx/src/x11shared/
-- snip --
mozilla/gfx/src/gtk/nsAntiAliasedGlyph.cpp
mozilla/gfx/src/gtk/nsAntiAliasedGlyph.h
mozilla/gfx/src/gtk/nsX11AlphaBlend.cpp
mozilla/gfx/src/gtk/nsX11AlphaBlend.h
mozilla/gfx/src/gtk/nsXFont.h
mozilla/gfx/src/gtk/nsXFontAAScaledBitmap.cpp
mozilla/gfx/src/gtk/nsXFontAAScaledBitmap.h
mozilla/gfx/src/gtk/nsXFontNormal.cpp
mozilla/gfx/src/gtk/nsXFontNormal.h
-- snip --

Maybe it's better to get a CVS admin move the sources on the CVS server instead
of using this diff ...

Comment 4

[hacker formerly known as [e-mail]]

Comment on attachment 63606 [details] [diff] [review]
Patch for 2002-01-01-08-trunk

r=cls on the Makefile.in changes

Comment 5

[kill this account]

These files do not have much cvs history so it would be okay with me to
either move them or just use the diff.

mozilla/gfx/src/gtk/nsAntiAliasedGlyph.cpp
mozilla/gfx/src/gtk/nsAntiAliasedGlyph.h
mozilla/gfx/src/gtk/nsX11AlphaBlend.cpp
mozilla/gfx/src/gtk/nsX11AlphaBlend.h
mozilla/gfx/src/gtk/nsXFont.h
mozilla/gfx/src/gtk/nsXFontAAScaledBitmap.cpp
mozilla/gfx/src/gtk/nsXFontAAScaledBitmap.h
mozilla/gfx/src/gtk/nsXFontNormal.cpp
mozilla/gfx/src/gtk/nsXFontNormal.h

Comment 6

[kill this account]

per email from Brendan, cls's r= is all that is needed for the Makefile.in
changes.

----------
checked in

Comment 7

[kill this account]

cvs removed the *.h files

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:enndeakin, could you have a look please?
For more information, please visit auto_nag documentation.