112522 - only run aasb on local X server

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[kill this account]

since anti-aliased scaled bitmap fonts (aasb: see bug 90813) use a large
amount of bandwidth we should not enabling them when the X server is remote.

Comment 1

[Roland Mainz]

bstell:
This is more a latency issue than a bandwidth issue (OK, it is one if you only
have 10baseT).
You can even get problems if Xterminal is connected via 1000baseT to a machine
which is on the other side of the city...

Comment 2

[kill this account]

Attachment: patch; disable aasb if X server not local

Uses gdk_get_use_xshm to test if X server is local.
This could be overly restrictive.

Comment 3

[Roland Mainz]

What about making this depend on bug 112506 ("prefs-item for AASB") and make a
"smart" option there:
Choices for the prefs item:
- Allways (both local and remove X11)
- Only local Xservers (=default)
- Never
 

Comment 4

[Roland Mainz]

midair-collision, sorry ...

Comment 5

[Roland Mainz]

Comment on attachment 59632 [details] [diff] [review]
patch; disable aasb if X server not local

r=[e-mail]

Comment 6

[kill this account]

> What about making this ... a "smart" option ...
> - Allways (both local and remove X11)
> - Only local Xservers (=default)
> - Never

If this is really impeding people (I still have not talked to anyone that 
actually has this problem) lets put in a fix for them so they can use
moz while we do the fine tuning.

I copied this to bug 112506, "Need font prefs panel item to turn AASB fonts 
on/off".

Comment 7

[Scott MacGregor]

Comment on attachment 59632 [details] [diff] [review]
patch; disable aasb if X server not local

The code looks innocuous to me and I'm okay putting an sr stamp on it assuming
you get an r= from a linux guru who has a good idea about this
stuff...blizzard? pavlov? 

tentative sr=mscott pending an appropriate r= from someone in the know.

Comment 8

[Roland Mainz]

> The code looks innocuous to me and I'm okay putting an sr stamp on it assuming
> you get an r= from a linux guru who has a good idea about this
> stuff...

See r= above ... :)

Comment 9

[Stuart Parmenter]

Comment on attachment 59632 [details] [diff] [review]
patch; disable aasb if X server not local

r=pavlov

Comment 10

[kill this account]

checked in

Comment 11

[Adam D. Moss]

Nice one... quick work.  :)

Comment 12

[Teruko Kobayashi]

Changed QA contact to [e-mail] since she is the QA contact for bug 
90813.