Closed Bug 1125260 Opened 11 years ago Closed 9 years ago

telemetry-dash job killer operates on GET requests instead of POST

Categories

(Webtools Graveyard :: Telemetry Server, defect)

Product:
Webtools Graveyard
Component:
Telemetry Server
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: benjamin, Unassigned)

Details

The telemetry-dash service which kills an ad-hoc worker is triggered by a GET link instead of a POSTed form. This is bad! If a browser decided to prefetch that link (which is not an unrealistic short-term future) users could end up accidentally killing their instances. I think this should be a POST method driven by a little kill form, to avoid any prefetching issues and make the intent clear.
COMPLETELY UNTESTED PR at https://github.com/mozilla/telemetry-server/pull/89
Assignee: nobody → benjamin
I would like to see a GET to this page display an "are you sure?" form, which submits via POST, resulting in the worker being killed.
Not a bad idea, but not something I have time for.
Assignee: benjamin → nobody
That project has been deprecated in favour of [1]. Closing this out. [1] https://github.com/mozilla/telemetry-analysis-service/
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.