Closed
Bug 1125283
Opened 7 years ago
Closed 7 years ago
KidFox: Restricted profiles - Disable snippets (promotional banner) support
Categories
(Firefox for Android Graveyard :: Profile Handling, defect)
Tracking
(firefox42 fixed)
RESOLVED
FIXED
Firefox 42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jchaulk, Assigned: sebastian)
References
Details
Attachments
(1 file)
1.42 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Updated•7 years ago
|
OS: Windows 8.1 → Android
Hardware: x86_64 → All
Version: unspecified → Trunk
Assignee | ||
Comment 1•7 years ago
|
||
Do we just want to disable our own 'Mozilla' snippets or do we want to short-circuit the banner API for all add-ons too?
Updated•7 years ago
|
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
Assignee | ||
Comment 2•7 years ago
|
||
Our conclusion was that we want to disable all banners/snippets for now.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
Assignee | ||
Comment 3•7 years ago
|
||
We've already code in place for guest mode. I just extended it to cover restricted profiles too.
Attachment #8639941 -
Flags: review?(ally)
Comment 4•7 years ago
|
||
Comment on attachment 8639941 [details] [diff] [review] 1125283-disable-snippets.patch Review of attachment 8639941 [details] [diff] [review]: ----------------------------------------------------------------- Ally is out sick this afternoon, so drive-by r+ :)
Attachment #8639941 -
Flags: review?(ally) → review+
Assignee | ||
Comment 5•7 years ago
|
||
url: https://hg.mozilla.org/integration/fx-team/rev/4a0743e93d6f2caf2c48031b1f74f89d1f855bef changeset: 4a0743e93d6f2caf2c48031b1f74f89d1f855bef user: Sebastian Kaspari <s.kaspari@gmail.com> date: Thu Jul 30 20:12:58 2015 +0200 description: Bug 1125283 - Restricted profiles: Disable snippets (promotional banner) support. r=margaret
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4a0743e93d6f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Updated•1 year ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•