Closed Bug 1125283 Opened 6 years ago Closed 6 years ago

KidFox: Restricted profiles - Disable snippets (promotional banner) support

Categories

(Firefox for Android Graveyard :: Profile Handling, defect)

Product:
Firefox for Android Graveyard
Component:
Profile Handling
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox42 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 42
Tracking Flags:
Tracking Status
firefox42 --- fixed

People

(Reporter: jchaulk, Assigned: sebastian)

References

Details

Attachments

(1 file)

1125283-disable-snippets.patch
1.42 KB, patch
Margaret
: review+
Details | Diff | Splinter Review 
No description provided.
Blocks: FFB
OS: Windows 8.1 → Android
Hardware: x86_64 → All
Version: unspecified → Trunk
Blocks: kidfox-v1
Do we just want to disable our own 'Mozilla' snippets or do we want to short-circuit the banner API for all add-ons too?
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
Our conclusion was that we want to disable all banners/snippets for now.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
We've already code in place for guest mode. I just extended it to cover restricted profiles too.
Attachment #8639941 - Flags: review?(ally)
Comment on attachment 8639941 [details] [diff] [review]
1125283-disable-snippets.patch

Review of attachment 8639941 [details] [diff] [review]:
-----------------------------------------------------------------

Ally is out sick this afternoon, so drive-by r+ :)
Attachment #8639941 - Flags: review?(ally) → review+
Depends on: 1187260
url:        https://hg.mozilla.org/integration/fx-team/rev/4a0743e93d6f2caf2c48031b1f74f89d1f855bef
changeset:  4a0743e93d6f2caf2c48031b1f74f89d1f855bef
user:       Sebastian Kaspari <s.kaspari@gmail.com>
date:       Thu Jul 30 20:12:58 2015 +0200
description:
Bug 1125283 - Restricted profiles: Disable snippets (promotional banner) support. r=margaret
https://hg.mozilla.org/mozilla-central/rev/4a0743e93d6f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.