KidFox: Restricted profiles - Disable snippets (promotional banner) support

RESOLVED FIXED in Firefox 42

Status

()

Product:
Firefox for Android
Component:
Profile Handling
Type:
defect
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
4 years ago

People

(Reporter: jchaulk, Assigned: sebastian)

Tracking

Version:
Trunk
Target:
Firefox 42
Platform:
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment)

1125283-disable-snippets.patch
1.42 KB, patch
Margaret
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
Blocks: FFB
OS: Windows 8.1 → Android
Hardware: x86_64 → All
Version: unspecified → Trunk
 (Reporter)

Updated

•
4 years ago
Blocks: kidfox-v1
 (Assignee)

Comment 1

•
4 years ago 
Do we just want to disable our own 'Mozilla' snippets or do we want to short-circuit the banner API for all add-ons too?
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
 (Assignee)

Comment 2

•
4 years ago 
Our conclusion was that we want to disable all banners/snippets for now.
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(margaret.leibovic)
Flags: needinfo?(bbermes)
 (Assignee)

Comment 3

•
4 years ago 
We've already code in place for guest mode. I just extended it to cover restricted profiles too.
Attachment #8639941 - Flags: review?(ally)

Comment 4

•
4 years ago 
Comment on attachment 8639941 [details] [diff] [review]
1125283-disable-snippets.patch

Review of attachment 8639941 [details] [diff] [review]:
-----------------------------------------------------------------

Ally is out sick this afternoon, so drive-by r+ :)
Attachment #8639941 - Flags: review?(ally) → review+
Depends on: 1187260
 (Assignee)

Comment 5

•
4 years ago 
url:        https://hg.mozilla.org/integration/fx-team/rev/4a0743e93d6f2caf2c48031b1f74f89d1f855bef
changeset:  4a0743e93d6f2caf2c48031b1f74f89d1f855bef
user:       Sebastian Kaspari <s.kaspari@gmail.com>
date:       Thu Jul 30 20:12:58 2015 +0200
description:
Bug 1125283 - Restricted profiles: Disable snippets (promotional banner) support. r=margaret

Comment 6

•
4 years ago 
https://hg.mozilla.org/mozilla-central/rev/4a0743e93d6f
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in before you can comment on or make changes to this bug.