Open Bug 1125300 Opened 5 years ago Updated 5 years ago

silent failures packaging up reftests

Categories

(Testing :: Reftest, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

People

(Reporter: catlee, Unassigned)

Details

In e.g. http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-linux64/1422034257/mozilla-central-linux64-bm77-build1-build51.txt.gz, tar has errors packing up some of the files:

10:17:56     INFO -  gmake[2]: Entering directory `/builds/slave/m-cen-l64-00000000000000000000/build/src/obj-firefox/layout/tools/reftest'
10:17:56     INFO -  ../../../config/nsinstall -D ../../../dist/test-stage/reftest && ../../../config/nsinstall -D ../../../dist/test-stage/reftest/tests
10:17:56     INFO -  (cd ../../../_tests/reftest/ && tar -chf - *) | (cd ../../../dist/test-stage/reftest && tar -xf -)
10:17:56     INFO -  /builds/slave/m-cen-l64-00000000000000000000/build/src/obj-firefox/_virtualenv/bin/python /builds/slave/m-cen-l64-00000000000000000000/build/src/layout/tools/reftest/print-manifest-dirs.py \
10:17:56     INFO -            /builds/slave/m-cen-l64-00000000000000000000/build/src \
10:17:56     INFO -            /builds/slave/m-cen-l64-00000000000000000000/build/src/layout/reftests/reftest.list \
10:17:56     INFO -            /builds/slave/m-cen-l64-00000000000000000000/build/src/testing/crashtest/crashtests.list \
10:17:56     INFO -            | (cd /builds/slave/m-cen-l64-00000000000000000000/build/src && xargs tar -chf -) \
10:17:56     INFO -            | (cd ../../../dist/test-stage/reftest/tests && tar -xf -)
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-15x15.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-16x16.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-17x17.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-1x1.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-256x256.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-2x2.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-31x31.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-32x32.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-33x33.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-3x3.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-4x4.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-5x5.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-6x6.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-7x7.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-8x8.png&mime=image: Cannot stat: No such file or directory
10:17:57     INFO -  tar: image/test/reftest/encoders-lossless/encoder.html?img=size-9x9.png&mime=image: Cannot stat: No such file or directory
10:17:58     INFO -  tar: Exiting with failure status due to previous errors
10:17:58     INFO -  gmake[2]: Leaving directory `/builds/slave/m-cen-l64-00000000000000000000/build/src/obj-firefox/layout/tools/reftest'
10:17:58     INFO -  /usr/bin/gmake -C ./testing/xpcshell stage-package
10:17:58     INFO -  gmake[2]: Entering directory `/builds/slave/m-cen-l64-00000000000000000000/build/src/obj-firefox/testing/xpcshell'
10:17:58     INFO -  ../../config/nsinstall -D ../../dist/test-stage/xpcshell/tests
10:17:58     INFO -  tar: manifestparser.py: Cannot stat: No such file or directory
10:17:58     INFO -  tar: Exiting with failure status due to previous errors
10:17:58     INFO -  (cd ../../_tests/xpcshell/ && tar -chf - *) | (cd ../../dist/test-stage/xpcshell/tests && tar -xf -)
10:17:58     INFO -  gmake[2]: Leaving directory `/builds/slave/m-cen-l64-00000000000000000000/build/src/obj-firefox/testing/xpcshell'
10:17:58     INFO -  /usr/bin/gmake -C ./js/src/tests stage-package


It looks like these errors are silently ignored, which maybe is fine for now, but could hide failures in the future.
This is definitely not ideal. Note that those specific errors are due to URL parameters in the test URLs which the packaging code doesn't know how to strip.
You need to log in before you can comment on or make changes to this bug.