Closed Bug 1125386 Opened 6 years ago Closed 6 years ago

Use an enum for exit frame token values

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: sstangl, Assigned: sstangl)

Details

Attachments

(1 file)

Token values must be unique, but are hardcoded numerically. These values are candidates for an enum.
Attachment #8553987 - Flags: review?(efaustbmo)
Comment on attachment 8553987 [details] [diff] [review]
0001-Use-an-enum-for-exit-frame-token-values.patch

Review of attachment 8553987 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, there are a few things like this which are pretty scarily put together, and which could be cleaned up. Nice.
Attachment #8553987 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/f7f224c79675
Assignee: nobody → sstangl
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.