1125398 - Add additional loads to GC ubench

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

Add in some more variants of mutator allocation behavior.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Split off harness.js from index.html

Refactoring: split out the ubench code into a separate file.

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Give each test load its own parameters

Some of the mutator allocation loads I will be adding really need their own set of garbage/frame, total garbage parameters. (eg, if you create as many weakmap entries as you do plain objects, you're gonna have a bad time.)

Also change around the UI a bit. Make it more obvious what's going on when you're running a test or tests. Indent stuff. More gooderify.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Benchmark load: self-referential WeakMap

Everyone's favorite GC nightmare: WeakMaps!

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Benchmark load: Pair of mutually recursive weakmaps

So certain optimizations would work really well if you're only considering a single weakmap. Make two of them.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Benchmark load: large objects

Benchmark large slots allocation

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Benchmark load; DOM textNodes

Now for the really interesting stuff: DOM nodes!

Hm, come to think of it, I ought to have one where I put expandos on stuff.

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: Benchmark load: large ArrayBuffers (for big malloc data)

ArrayBuffer objects are small and malloc a bunch of data. Good test.

Comment 8

[Steve Fink [:sfink] [:s:]]

Attachment: Benchmark load: arrays of Map (for foreground finalized)

Let's see how much we can suffer from foreground finalization.

Comment 9

[Terrence Cole [:terrence]]

Comment on attachment 8554006 [details] [diff] [review]
Give each test load its own parameters

Review of attachment 8554006 [details] [diff] [review]:
-----------------------------------------------------------------

Much nicer.

::: js/src/devtools/gc-ubench/index.html
@@ +10,5 @@
>    <script src="benchmarks/globalArrayArrayLiteral.js"></script>
>    <script src="benchmarks/globalArrayLargeArray.js"></script>
>    <script src="benchmarks/globalArrayObjectLiteral.js"></script>
>    <script src="benchmarks/globalArrayReallocArray.js"></script>
> +  <script src="benchmarks/selfCyclicWeakMap.js"></script>

I guess this needs to move down a couple patches.

@@ +25,5 @@
>      <input type="button" id="stop" value="Pause" onclick="stopstart()"></input>
>  </div>
>  
>  <div>
> +    Duration: <input type="text" id="test-duration" size=3 value="8" onchange="duration_changed()"></input>s

"" around the 3 in size=3.

Comment 10

[Terrence Cole [:terrence]]

Comment on attachment 8554008 [details] [diff] [review]
Benchmark load: self-referential WeakMap

Review of attachment 8554008 [details] [diff] [review]:
-----------------------------------------------------------------

I winced reading this. You'll also want to move the import <script> from the prior patch to this patch.

Comment 11

[Terrence Cole [:terrence]]

Comment on attachment 8554010 [details] [diff] [review]
Benchmark load: Pair of mutually recursive weakmaps

Review of attachment 8554010 [details] [diff] [review]:
-----------------------------------------------------------------

Heh.

Comment 12

[Terrence Cole [:terrence]]

Comment on attachment 8554011 [details] [diff] [review]
Benchmark load: large objects

Review of attachment 8554011 [details] [diff] [review]:
-----------------------------------------------------------------

Yup. This should be the slots equivalent of globalArrayReallocArray.

Comment 13

[Terrence Cole [:terrence]]

Comment on attachment 8554013 [details] [diff] [review]
Benchmark load; DOM textNodes

Review of attachment 8554013 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/devtools/gc-ubench/benchmarks/textNodes.js
@@ +8,5 @@
> +    unload: () => { garbage = []; garbageIndex = 0; },
> +
> +    defaultGarbagePerFrame: "100K",
> +    defaultGarbageTotal: "8",
> +    

Whitespace at end of line.

@@ +12,5 @@
> +    
> +    makeGarbage: (N) => {
> +        var a = [];
> +        for (var i = 0; i < N; i++)
> +            a.push(document.createTextNode("t" + i));

We'll also want a test with extremely large text nodes.

Comment 14

[Terrence Cole [:terrence]]

Comment on attachment 8554015 [details] [diff] [review]
Benchmark load: large ArrayBuffers (for big malloc data)

Review of attachment 8554015 [details] [diff] [review]:
-----------------------------------------------------------------

I guess those don't get nursery alloc with inline storage anymore?

Comment 15

[Steve Fink [:sfink] [:s:]]

(In reply to Terrence Cole [:terrence] from comment #14)
> Comment on attachment 8554015 [details] [diff] [review]
> Benchmark load: large ArrayBuffers (for big malloc data)
> 
> Review of attachment 8554015 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I guess those don't get nursery alloc with inline storage anymore?

Large ones do not because they're large. Then again, small ones don't either, because they have finalizers. :-)

But it's probably not a loss, because small typed arrays and typed objects store their data inline now as long as you don't ask for their buffers. And I *think* they're nursery-allocatable too.

Comment 16

[Steve Fink [:sfink] [:s:]]

Attachment: Benchmark load: simple events

Borrowing from smaug's event creation microbenchmark.

Comment 17

[Steve Fink [:sfink] [:s:]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/90623a5d6c0c
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b8257c0c97ad
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/abe775af8073
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/4bbb59685268
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/cbf059987742
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/46cde5a19b8d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/8a5b30881128
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/97c12091bda5
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b5a4e4c8ed85

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/90623a5d6c0c
https://hg.mozilla.org/mozilla-central/rev/b8257c0c97ad
https://hg.mozilla.org/mozilla-central/rev/abe775af8073
https://hg.mozilla.org/mozilla-central/rev/4bbb59685268
https://hg.mozilla.org/mozilla-central/rev/cbf059987742
https://hg.mozilla.org/mozilla-central/rev/46cde5a19b8d
https://hg.mozilla.org/mozilla-central/rev/8a5b30881128
https://hg.mozilla.org/mozilla-central/rev/97c12091bda5
https://hg.mozilla.org/mozilla-central/rev/b5a4e4c8ed85