Closed Bug 1125401 Opened 5 years ago Closed 5 years ago

Handle multipart images correctly by replacing ProgressTracker::IsLoading with checks of the correct progress flags

Categories

(Core :: ImageLib, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox36 --- fixed
firefox37 --- fixed
firefox38 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

Right now ProgressTracker::IsLoading() checks FLAG_LOAD_COMPLETE, which was OK when we reset that flag for every part of a multipart image.

Now that we don't, that's wrong. Different callers of IsLoading() need different things, so I think we should just rip it out and replace all callsites with checks for either FLAG_LOAD_COMPLETE or FLAG_LAST_PART_COMPLETE.
Attachment #8554016 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/9ad3baed1c70
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Comment on attachment 8554016 [details] [diff] [review]
Replace ProgressTracker::IsLoading() with checks of the correct progress flags

Approval Request Comment
[Feature/regressing bug #]: Bug 1112972
[User impact if declined]: MJPEG streams do not stop loading when the tab is closed, wasting user bandwidth and CPU time.
[Describe test coverage new/current, TreeHerder]: On central.
[Risks and why]: Low risk; behavior change is limited to MJPEG streams.
[String/UUID change made/needed]: None.
Attachment #8554016 - Flags: approval-mozilla-aurora?
Attachment #8554016 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Seth, does this affect 36 too? thanks
Flags: needinfo?(seth)
(In reply to Sylvestre Ledru [:sylvestre] from comment #5)
> Seth, does this affect 36 too? thanks

Nope, should only be on 37 and 38. Thanks for the quick approval!
Flags: needinfo?(seth)
Comment on attachment 8554016 [details] [diff] [review]
Replace ProgressTracker::IsLoading() with checks of the correct progress flags

Approval Request Comment
[Feature/regressing bug #]: Unknown.
[User impact if declined]: MJPEG streams and webcams stutter and don't render correctly.
[Describe test coverage new/current, TreeHerder]: Already in Firefox 38 and 37.
[Risks and why]: Low. This is a small bug fix for bug 1112956, which actually fixes the issue.
[String/UUID change made/needed]: None.
Attachment #8554016 - Flags: approval-mozilla-beta?
Attachment #8554016 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.