Closed
Bug 1125512
Opened 8 years ago
Closed 8 years ago
Wrong error message is shown when running jstests.py with wrong js shell path.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: arai, Assigned: arai)
Details
Attachments
(4 files, 1 obsolete file)
9.02 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
32.02 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
14.59 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
43.01 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
When running jstests.py with wrong js shell path, following message is shown: > Can't find config/autoconf.mk on a directory containing the JS shell (searched from %s) it's incompatibility problem between print statement and print function. https://dxr.mozilla.org/mozilla-central/source/js/src/tests/lib/manifest.py#61
Assignee | ||
Comment 1•8 years ago
|
||
"%s" in the messsage should be replaced with jsdir variable.
Assignee | ||
Comment 2•8 years ago
|
||
I guess this file is not used on try server now. Tested locally. $ ./jstests.py /usr/bin/js Can't find config/autoconf.mk on a directory containing the JS shell (searched from /usr/bin/js)
Attachment #8554260 -
Flags: review?(terrence)
Comment 3•8 years ago
|
||
Comment on attachment 8554260 [details] [diff] [review] Fix error message when running jstests.py with wrong js shell path. Review of attachment 8554260 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/tests/lib/manifest.py @@ +57,5 @@ > break > > if path == None: > + print (("Can't find config/autoconf.mk on a directory containing the JS shell" > + " (searched from %s)") % jsdir) Python 2.7 is required, so could we switch this to use .format() instead?
Assignee | ||
Comment 4•8 years ago
|
||
As a first step, switched to `.format()` in manifest.py, and applied some styles. After this patch gets ready, I'll prepare patches for other files.
Attachment #8554260 -
Attachment is obsolete: true
Attachment #8554260 -
Flags: review?(terrence)
Attachment #8554721 -
Flags: review?(terrence)
Comment 5•8 years ago
|
||
Comment on attachment 8554721 [details] [diff] [review] Part 1: Use .format() instead of module operator in manifest.py. Review of attachment 8554721 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8554721 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Thank you for reviewing :) Okay, prepared 3 more patches.
Attachment #8555178 -
Flags: review?(terrence)
Assignee | ||
Comment 7•8 years ago
|
||
Forgot to add link to try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=855f19857f68
Attachment #8555179 -
Flags: review?(terrence)
Assignee | ||
Comment 8•8 years ago
|
||
Attachment #8555180 -
Flags: review?(terrence)
Updated•8 years ago
|
Attachment #8555178 -
Flags: review?(terrence) → review+
Updated•8 years ago
|
Attachment #8555179 -
Flags: review?(terrence) → review+
Updated•8 years ago
|
Attachment #8555180 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 9•8 years ago
|
||
Thank you! :D https://hg.mozilla.org/integration/mozilla-inbound/rev/63e93ddb740f https://hg.mozilla.org/integration/mozilla-inbound/rev/3de67cecd18d https://hg.mozilla.org/integration/mozilla-inbound/rev/0c982514eb25 https://hg.mozilla.org/integration/mozilla-inbound/rev/ce00599c23e2
Comment 10•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/63e93ddb740f https://hg.mozilla.org/mozilla-central/rev/3de67cecd18d https://hg.mozilla.org/mozilla-central/rev/0c982514eb25 https://hg.mozilla.org/mozilla-central/rev/ce00599c23e2
Assignee: nobody → arai_a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•