1125512 - Wrong error message is shown when running jstests.py with wrong js shell path.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

When running jstests.py with wrong js shell path, following message is shown:
> Can't find config/autoconf.mk on a directory containing the JS shell (searched from %s)

it's incompatibility problem between print statement and print function.
https://dxr.mozilla.org/mozilla-central/source/js/src/tests/lib/manifest.py#61

Comment 1

[Tooru Fujisawa [:arai]]

"%s" in the messsage should be replaced with jsdir variable.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Fix error message when running jstests.py with wrong js shell path.

I guess this file is not used on try server now.
Tested locally.

$ ./jstests.py /usr/bin/js
Can't find config/autoconf.mk on a directory containing the JS shell (searched from /usr/bin/js)

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8554260 [details] [diff] [review]
Fix error message when running jstests.py with wrong js shell path.

Review of attachment 8554260 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/lib/manifest.py
@@ +57,5 @@
>                  break
>  
>          if path == None:
> +            print (("Can't find config/autoconf.mk on a directory containing the JS shell"
> +                    " (searched from %s)") % jsdir)

Python 2.7 is required, so could we switch this to use .format() instead?

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Part 1: Use .format() instead of module operator in manifest.py.

As a first step, switched to `.format()` in manifest.py, and applied some styles.
After this patch gets ready, I'll prepare patches for other files.

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 8554721 [details] [diff] [review]
Part 1: Use .format() instead of module operator in manifest.py.

Review of attachment 8554721 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Part 2: Use .format() instead of modulo operator in js test libs.

Thank you for reviewing :)

Okay, prepared 3 more patches.

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Part 3: Use .format() instead of modulo operator in jstests.py.

Forgot to add link to try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=855f19857f68

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Part 4: Use .format() instead of modulo operator in jit_test.py.

Comment 9

[Tooru Fujisawa [:arai]]

Thank you! :D

https://hg.mozilla.org/integration/mozilla-inbound/rev/63e93ddb740f
https://hg.mozilla.org/integration/mozilla-inbound/rev/3de67cecd18d
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c982514eb25
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce00599c23e2

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63e93ddb740f
https://hg.mozilla.org/mozilla-central/rev/3de67cecd18d
https://hg.mozilla.org/mozilla-central/rev/0c982514eb25
https://hg.mozilla.org/mozilla-central/rev/ce00599c23e2