Intermittent browser_webconsole_assert.js | only six messages are displayed, no output from the true assert - Got 5, expected 6

RESOLVED FIXED in Firefox 37

Status

RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: philor, Assigned: sjakthol)

Tracking

({intermittent-failure})

Trunk
Firefox 38
x86
Mac OS X
intermittent-failure
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox36 unaffected, firefox37 fixed, firefox38 fixed, firefox-esr31 unaffected)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 61

4 years ago
Created attachment 8564489 [details] [diff] [review]
webconsole-assert-failure.patch

Console messages when everything works
> 09:38:07.650 test()
> 09:38:07.667 undefined
> 09:38:07.668 "start"1 test-console-assert.html:12:8
> 09:38:07.668 "false assert"1 test-console-assert.html:13:8
> 09:38:07.669 "falsy assert"1 test-console-assert.html:14:8
> 09:38:07.669 "end"1 test-console-assert.html:16:8
> TEST-PASS | browser/devtools/webconsole/test/browser_webconsole_assert.js | only six messages are displayed, no output from the true assert

Console messages when failure occurs:
> 09:38:12.270 test()
> 09:38:12.285 "start"1 test-console-assert.html:12:8
> 09:38:12.286 "false assert"1 test-console-assert.html:13:8
> 09:38:12.287 "falsy assert"1 test-console-assert.html:14:8
> 09:38:12.288 "end"1 test-console-assert.html:16:8
> TEST-UNEXPECTED-FAIL | browser/devtools/webconsole/test/browser_webconsole_assert.js | only six messages are displayed, no output from the true assert - Got 5, expected 6

Thus it appears that the output "undefined" from executing "test()" in the console is not always printed before the messages are logged to the console.

This patch makes the test wait for the output from test() before asserting on the number of messages.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=02459324bd88
Assignee: nobody → sjakthol
Status: NEW → ASSIGNED
Attachment #8564489 - Flags: review?(past)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment on attachment 8564489 [details] [diff] [review]
webconsole-assert-failure.patch

Review of attachment 8564489 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8564489 - Flags: review?(past) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/integration/fx-team/rev/e1d276c611ea
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/e1d276c611ea
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
status-firefox36: --- → unaffected
status-firefox37: --- → affected
status-firefox-esr31: --- → unaffected
Created attachment 8676906 [details] [diff] [review]
part 1 - pass dependencies file to file_generate.py

In addition to their inputs declared in moz.build files, generated files
may also depend on other files, such as #includes in preprocessed files.
Let's provide a place for file_generate.py to write out those extra
dependencies.
Attachment #8676906 - Flags: review?(mh+mozilla)
Attachment #8676906 - Attachment is obsolete: true
Attachment #8676906 - Flags: review?(mh+mozilla)

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.