1125530 - Remove TREEHERDER_DATABASE_PORT setting since it's mostly unused

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

We only pass it in some cases, so setting it to anything other than the default will break all the places where we don't use it, as far as I can see:
https://github.com/mozilla/treeherder-service/search?utf8=%E2%9C%93&q=TREEHERDER_DATABASE_PORT

Let's just remove the option, since the only place we use it:
https://github.com/mozilla/treeherder-service/blob/956c84e3e2d140da01369a7178d61acaac62d2d0/treeherder/settings/base.py#L335

Is an optional param anyway:
https://docs.djangoproject.com/en/1.7/ref/settings/#port

Comment 1

[Ed Morley [:emorley]]

Attachment: Remove the TREEHERDER_DATABASE_PORT pref

Comment 2

[Mauro Doglio [:mdoglio]]

sgtm. if one day we use the django db connections for all the databases it will be easy to reintroduce this setting.

Comment 3

[Ed Morley [:emorley]]

(In reply to Mauro Doglio [:mdoglio] from comment #2)
> sgtm. if one day we use the django db connections for all the databases it
> will be easy to reintroduce this setting.

The django db connections are already used (if we're talking about the same thing) - removing the pref just means they fall back to the default port, so I don't think we'd need to add this back (unless we start splitting the DB onto different hosts with different ports or something).

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/fc88dcf73d803bcf05cd78a8ab325083f181c56f
Bug 1125530 - Remove the TREEHERDER_DATABASE_PORT pref

We only pass it in some cases, so setting it to anything other than the
default will break all the places where we don't use it. Django doesn't
require it is set, since it will fall back to the default port for that
engine type anyway.