1125532 - Tab container's "underflow" event handler doesn't correctly clear out removing tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

There's this loop in the "underflow" event handler:

        for (let tab of tabs.tabbrowser._removingTabs)
          tabs.tabbrowser.removeTab(tab);

(http://hg.mozilla.org/mozilla-central/annotate/bb70f0e4a567/browser/base/content/tabbrowser.xml#l3652)

In that loop, removeTab removes the tab from the _removingTabs array, which then causes the loop to miss the next element. To catch all elements, we need to work with a copy of that array, e.g.:

        for (let tab of Array.from(tabs.tabbrowser._removingTabs))
          ...

Comment 1

[Abdelrahman Ahmed [:abdelrahman]]

Attachment: rev 1 - maintaining loop

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8554222 [details] [diff] [review]
rev 1 - maintaining loop

looks good

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/486f15ad8a97

Comment 4

[Abdelrahman Ahmed [:abdelrahman]]

Dão,
when you have more new bugs, just tell me to work on :)

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/486f15ad8a97