Closed
Bug 1125532
Opened 9 years ago
Closed 9 years ago
Tab container's "underflow" event handler doesn't correctly clear out removing tabs
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 38
People
(Reporter: dao, Assigned: abdelrahman, Mentored)
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
971 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
There's this loop in the "underflow" event handler: for (let tab of tabs.tabbrowser._removingTabs) tabs.tabbrowser.removeTab(tab); (http://hg.mozilla.org/mozilla-central/annotate/bb70f0e4a567/browser/base/content/tabbrowser.xml#l3652) In that loop, removeTab removes the tab from the _removingTabs array, which then causes the loop to miss the next element. To catch all elements, we need to work with a copy of that array, e.g.: for (let tab of Array.from(tabs.tabbrowser._removingTabs)) ...
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8554222 -
Flags: review?(dao)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8554222 [details] [diff] [review] rev 1 - maintaining loop looks good
Attachment #8554222 -
Flags: review?(dao) → review+
Reporter | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/486f15ad8a97
Assignee: nobody → a.ahmed1026
Assignee | ||
Comment 4•9 years ago
|
||
Dão, when you have more new bugs, just tell me to work on :)
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/486f15ad8a97
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
You need to log in
before you can comment on or make changes to this bug.
Description
•