Closed Bug 1125579 Opened 6 years ago Closed 6 years ago

Implement ExecutableAllocator::cacheFlush for ARM on BSDs

Categories

(Core :: JavaScript Engine: JIT, defect)

ARM
FreeBSD
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

FreeBSD trunk can use __clear_cache() from compiler-rt. Like NetBSD it's implemented via sysarch(ARM_SYNC_ICACHE), also in libgcc. Does OpenBSD want it too?

https://github.com/llvm-mirror/compiler-rt/commit/dc4badd

Refiled with improvements from downstream bug for esr24.
Attachment #8554230 - Flags: review?(jdemooij)
Attachment #8554230 - Flags: feedback?(martin)
OpenBSD/arm is not a target for me atm.
Comment on attachment 8554230 [details] [diff] [review]
use __clear_cache on FreeBSD and NetBSD

__clear_cache() is the best way for NetBSD obviously - we might not have it on some older (still supported) NetBSD releases, but I doubt anyone will try to get Firefox working for arm on those anyway. In any case, we would deal with that localy (e.g. by pulling up the __clear_cache() changes to older libc)
Attachment #8554230 - Flags: feedback?(martin) → feedback+
Attachment #8554230 - Flags: review?(jdemooij) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/86e9422940ed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.