Closed
Bug 1125579
Opened 9 years ago
Closed 9 years ago
Implement ExecutableAllocator::cacheFlush for ARM on BSDs
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file)
|
1.13 KB,
patch
|
jandem
:
review+
martin
:
feedback+
|
Details | Diff | Splinter Review |
FreeBSD trunk can use __clear_cache() from compiler-rt. Like NetBSD it's implemented via sysarch(ARM_SYNC_ICACHE), also in libgcc. Does OpenBSD want it too? https://github.com/llvm-mirror/compiler-rt/commit/dc4badd Refiled with improvements from downstream bug for esr24.
Attachment #8554230 -
Flags: review?(jdemooij)
Attachment #8554230 -
Flags: feedback?(martin)
|
||
Comment 3•9 years ago
|
||
OpenBSD/arm is not a target for me atm.
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8554230 [details] [diff] [review] use __clear_cache on FreeBSD and NetBSD __clear_cache() is the best way for NetBSD obviously - we might not have it on some older (still supported) NetBSD releases, but I doubt anyone will try to get Firefox working for arm on those anyway. In any case, we would deal with that localy (e.g. by pulling up the __clear_cache() changes to older libc)
Attachment #8554230 -
Flags: feedback?(martin) → feedback+
|
||
Updated•9 years ago
|
Attachment #8554230 -
Flags: review?(jdemooij) → review+
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/86e9422940ed
Assignee: nobody → jbeich
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86e9422940ed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•