Closed Bug 1125586 Opened 9 years ago Closed 9 years ago

Use the new 'require_host_type' datasource option to avoid accidental master host usage

Categories

(Tree Management :: Treeherder, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

To help avoid situations like bug 1125464, a new option was added to datasource to enforce that an explicit host_type has been specified, rather than silently falling back to the default of master_host.

Once we have the updated datasource library (bug 1125585), we should start using 'require_host_type'.
Blocks: 1125464
Attachment #8556583 - Flags: review?(mdoglio)
Attachment #8556583 - Flags: review?(mdoglio) → review+
Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/b8e5eb39a2ff6f6108ca4b2e9fb485208246e949
Bug 1125586 - Enable the 'require_host_type' datasource option

Uses the new datasource option added by bug 1125585, to enforce that a
host_type is always specified, and thus avoid silently falling back to
the master_host when the read_host might have been more suitable.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: