Closed Bug 1125628 Opened 5 years ago Closed 5 years ago

Implement parts of [[DefineOwnProperty]] for typed arrays

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch define-property-on-typed-array (obsolete) — Splinter Review
We still don't handle indexes completely, but it's a step in the right direction. Sadly NativeDefineProperty totally goes behind our back right now.
Attachment #8554277 - Flags: review?(jwalden+bmo)
I forgot to change DefineProperties and didn't include my test.
Assignee: nobody → evilpies
Attachment #8554277 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8554277 - Flags: review?(jwalden+bmo)
Attachment #8554300 - Flags: review?(jwalden+bmo)
Comment on attachment 8554300 [details] [diff] [review]
v2 - implement [[DefineOwnProperty]]

Review of attachment 8554300 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_6/TypedArray/object-defineproperty.js
@@ +1,2 @@
> +var obj = new Int32Array(2);
> +obj[0] = 100;

Good test, but.  Modify a few of these (successful) definitions by biasing them by 2**32 in either direction.  And add a few tests along these lines with Uint8ClampedArray, that check that negative values clamp to 0 and that values >= 255 clamp to 255.
Attachment #8554300 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/b35d3104b6bd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.