Closed Bug 1125638 Opened 5 years ago Closed 5 years ago

nsGTKRemoteService.h:47:16: warning: 'SetDesktopStartupIDOrTimestamp' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]

Categories

(Core Graveyard :: X-remote, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla38

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warning:
{
toolkit/components/remote/nsGTKRemoteService.h:47:16: warning: 'SetDesktopStartupIDOrTimestamp' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
}

Patch coming up to fix this w/ MOZ_OVERRIDE for this class and for nsQtRemoteService.h as well (which has the only other impl of this function).
Attached patch fixSplinter Review
Attachment #8554285 - Flags: review?(karlt)
Attachment #8554285 - Flags: review?(karlt) → review+
https://hg.mozilla.org/mozilla-central/rev/205717a8d35e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.