Closed Bug 1125702 Opened 5 years ago Closed 5 years ago

[Bluetooth2] Make enable/disable BT and set adapter name certified only.

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S5 (6feb)

People

(Reporter: yrliou, Assigned: yrliou)

Details

(Whiteboard: [webbt-api])

Attachments

(1 file, 1 obsolete file)

During security review, we have a final agreement with UX and security team that we will have a single bluetooth permission for our new APIs and make sensitive methods/attributes certified only.
We need to mark these three methods as certified only since they are identified as sensitive methods during the security review.
Hi Ben,

This patch is to mark security sensitive functions as certified only.
Please help to review this patch.
I will ask for a DOM peer's review afterwards.

Thanks,
Jocelyn
Attachment #8555032 - Flags: review?(btian)
Comment on attachment 8555032 [details] [diff] [review]
Bug 1125702: Make enable/disable BT and set adapter name certified only for Bluetooth API2.

Review of attachment 8555032 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Please request a DOM peer review as well.
Attachment #8555032 - Flags: review?(btian) → review+
Comment on attachment 8555032 [details] [diff] [review]
Bug 1125702: Make enable/disable BT and set adapter name certified only for Bluetooth API2.

Hi Boris,

This patch is to mark several methods certified only since they have been identified as sensitive methods from security team.
Could you help to review thid WebIDL change?

Thanks,
Jocelyn
Attachment #8555032 - Flags: review?(bzbarsky)
Comment on attachment 8555032 [details] [diff] [review]
Bug 1125702: Make enable/disable BT and set adapter name certified only for Bluetooth API2.

r=me
Attachment #8555032 - Flags: review?(bzbarsky) → review+
No try server result since bluetooth2 won't be built.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f0dd5841ef13
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.