1125703 - Disable some Gaia Keyboard Build Integration Tests until bug 1119731 is fixed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

Due to false positive of Gb as described bug 1119731 comment 3, two keyboard build integration test failures are currently going unnoticed:

TEST-UNEXPECTED-FAIL | apps/keyboard/test/build/integration/keyboard_test.js | Keyboard layouts building tests APP=keyboard GAIA_KEYBOARD_LAYOUTS=* GAIA_KEYBOARD_PRELOAD_DICT_LAYOUTS=* make
AssertionError: Checking js/settings/dictionaries.json in /builds/slave/test/gaia/profile/webapps/keyboard.gaiamobile.org/application.zip: expected [ Array(56) ] to deeply equal [ Array(54) ]

TEST-UNEXPECTED-FAIL | apps/keyboard/test/build/integration/keyboard_test.js | Keyboard layouts building tests APP=keyboard GAIA_KEYBOARD_LAYOUTS=noPreloadDictRequired GAIA_KEYBOARD_PRELOAD_DICT_LAYOUTS="" make
AssertionError: Checking js/settings/dictionaries.json in /builds/slave/test/gaia/profile/webapps/keyboard.gaiamobile.org/application.zip: expected [ Array(52) ] to deeply equal [ Array(50) ]

And Gb should have been perma-red'ing -- We'll disable these two specific tests until bug 1119731 is resolved.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Waiting for Gaia-Try.

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8554354 [details] [review]
Patch (PR @ GitHub)

(I didn't know there was a test.skip() so I had originally changed test code logics and wasted some time) -- The two tests are now test.skip()'ed.

Ricky, I think this is your call as test code logics are not touched.

Will file the actual-fix bug when this is green-lighted.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8554354 [details] [review]
Patch (PR @ GitHub)

r+. Please be aware of the problem in treeherder, green light doesn't mean that there are no failures.

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Yes, I'll take extra care of it. Thanks Ricky!

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

TBPL is all green there and no failure in Gb logs. I still don't have GitHub permission as of writing so adding the keyword for now.

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Bug 1125753 will fix the actual test failures.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/bbe4036b0f00590fe70531ff00151408b45644f6

Comment 8

[John Lu [:mnjul][Please NI or I'll miss]]

Thanks Ryan!