Closed Bug 1125704 Opened 7 years ago Closed 7 years ago

[Stingray] Notification toaster exceeds the screen area.

Categories

(Firefox OS Graveyard :: Gaia::TV::System, defect)

Other
FreeBSD
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: hamasaki.koji.dev, Assigned: dwi2)

Details

(Whiteboard: [Stingray-Branch][picked 1/28])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review
If title and/or body is long, notificaion-toaster exceeds the screen area.
I believe this is not mozilla's intention.
Could you prepare the patch about this issue?
Assignee: nobody → tzhuang
Group: panasonic-confidential
Status: NEW → ASSIGNED
Component: Gaia::System → Gaia::TV::System
Attached file pull request
Hi John,

Please help to review the patch. The max-length 40rem value is suggested by Scott after offline discussion.

Thanks
Attachment #8554389 - Flags: review?(im)
Comment on attachment 8554389 [details] [review]
pull request

Looks good to me. And sorry about I forgot this case.
Attachment #8554389 - Flags: review?(im) → review+
Landed on master
https://github.com/mozilla-b2g/gaia/commit/0e8d0204e59bb23984a7db0606f5ff5458db05bd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Stingray-Branch]
Whiteboard: [Stingray-Branch] → [Stingray-Branch][picked 1/28]
You need to log in before you can comment on or make changes to this bug.