[Stingray] Notification toaster exceeds the screen area.

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: hamasaki.koji.dev, Assigned: dwi2)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Stingray-Branch][picked 1/28])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
If title and/or body is long, notificaion-toaster exceeds the screen area.
I believe this is not mozilla's intention.
Could you prepare the patch about this issue?
(Reporter)

Updated

4 years ago
Blocks: 1115485
(Reporter)

Updated

4 years ago
No longer blocks: 1115485
Depends on: 1115485
(Reporter)

Updated

4 years ago
Blocks: 1115485
No longer depends on: 1115485

Updated

4 years ago
Blocks: 1115611

Updated

4 years ago
Assignee: nobody → tzhuang

Updated

4 years ago
Group: panasonic-confidential
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
Component: Gaia::System → Gaia::TV::System
(Assignee)

Comment 1

4 years ago
Created attachment 8554389 [details] [review]
pull request

Hi John,

Please help to review the patch. The max-length 40rem value is suggested by Scott after offline discussion.

Thanks
Attachment #8554389 - Flags: review?(im)
Comment on attachment 8554389 [details] [review]
pull request

Looks good to me. And sorry about I forgot this case.
Attachment #8554389 - Flags: review?(im) → review+
(Assignee)

Comment 3

4 years ago
Landed on master
https://github.com/mozilla-b2g/gaia/commit/0e8d0204e59bb23984a7db0606f5ff5458db05bd
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [Stingray-Branch]
(Reporter)

Updated

4 years ago
Whiteboard: [Stingray-Branch] → [Stingray-Branch][picked 1/28]
You need to log in before you can comment on or make changes to this bug.