1125713 - Browser API: Add event for page download progress

Status: NEW

(Core :: DOM: Core & HTML, defect)

Description

[Paul Rouget [:paul]]

Today, the browser API only tells if a frame is loading or not. It makes it impossible to build a progress bar.

Having something like `onProgressChange(CurTotalProgress,MaxTotalProgress)` from nsIWebProgressListener would probably work.

Comment 1

[Josh Matthews [:jdm]]

There's semi-related discussion in https://github.com/whatwg/fetch/issues/19, too.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: progress.patch

This patch adds loadprogresschanged event.

Comment 3

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7c68c4389d6

Comment 4

[Paul Rouget [:paul]]

Attachment: dump

Results are not very satisfying. Pretty often, the max value is lower than the current value. Sometimes the max value is 10 times smaller than the current value.

Not sure what we can do about it.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c7c68c4389d6

Comment 6

[Ting-Yu Chou [:ting] (away)]

This makes chorme process main thread quite busy when launch an app on FxOS and delay sync IPCs from child. Do we need this event all the time?

Comment 7

[Paul Rouget [:paul]]

We actually need only the first download progress event to indicate download has started.

Comment 8

[Ting-Yu Chou [:ting] (away)]

I have tried to gather visuallyLoaded event of launching SMS on my Flame [1], with and without the path here:

                   AVG          MED          MIN          MAX          STD
With the patch     1642.380661  1620.661354  1528.798750  1822.307707  99.2765441
Without the patch  1355.260708  1363.919010  1234.469479  1515.148748  85.04832144

It's ~300ms regression. Can we back this out and revise the patch if we need only the first download progress event?

Version:
  Gaia: c4835abe080b20aaec6e736ad6f4a74c444c244c
  Gecko: https://hg.mozilla.org/mozilla-central/rev/fd8e079d6335

Device:
  Flame 1024MB v18D

Test steps:
  1. Launch SMS with empty load
  2. Kill the app
  3. Wait for 5s, go to 1
  4. Repeat 1-3 for 10 times

Comment 9

[[:fabrice] Fabrice Desré]

Ting-Yu, please backout.

Comment 10

[Ting-Yu Chou [:ting] (away)]

I couldn't find a backout flag, how should I request that?

Comment 11

[[:fabrice] Fabrice Desré]

(In reply to Ting-Yu Chou [:ting] from comment #10)
> I couldn't find a backout flag, how should I request that?

There's no flag, just do it yourself.

Comment 12

[Ting-Yu Chou [:ting] (away)]

(In reply to Fabrice Desré [:fabrice] from comment #11)
> (In reply to Ting-Yu Chou [:ting] from comment #10)
> > I couldn't find a backout flag, how should I request that?
> 
> There's no flag, just do it yourself.

I have only level 1 access...

Comment 13

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/d6d4cf466565

Comment 14

[Andrea Marchesini [:baku]]

(In reply to Paul Rouget [:paul] from comment #7)
> We actually need only the first download progress event to indicate download
> has started.

Well... can you use mozbrowserloadstart for that?

Comment 15

[Paul Rouget [:paul]]

(In reply to Andrea Marchesini (:baku) from comment #14)
> (In reply to Paul Rouget [:paul] from comment #7)
> > We actually need only the first download progress event to indicate download
> > has started.
> 
> Well... can you use mozbrowserloadstart for that?

We want to do something similar to what Firefox does: indicate when load starts (reaching the server, grey throbber), indicate when the server responded (starting downloading, blue throbber).

So mozbrowserloadstart is not enough.

Comment 16

[Paul Rouget [:paul]]

Attachment: v2

I've updated the patch to only send an event (mozbrowserconnected) once the server has been reached. The goal is to be able to differentiate the phase when the browser is connecting to the server and the phase when the browser is downloading and loading the page.

Comment 17

[Paul Rouget [:paul]]

Attachment: v2

Comment 18

[Paul Rouget [:paul]]

This still sends multiple "connected" event. We should send only one.

Comment 19

[Paul Rouget [:paul]]

For Servo, we are planning to fire a "mozbrowserconnected" event once the server has been reached.

Comment 20

[Paul Rouget [:paul]]

See https://github.com/servo/servo/issues/9382

Comment 21

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.