1125753 - Fix broken Gaia Keyboard Build Integration Tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

+++ This bug was initially created as a clone of Bug #1125703 +++

Two keyboard build integration test failures are currently disabled, as of bug 1125703, due to false positive of Gb as described bug 1119731 comment 3:

TEST-UNEXPECTED-FAIL | apps/keyboard/test/build/integration/keyboard_test.js | Keyboard layouts building tests APP=keyboard GAIA_KEYBOARD_LAYOUTS=* GAIA_KEYBOARD_PRELOAD_DICT_LAYOUTS=* make
AssertionError: Checking js/settings/dictionaries.json in /builds/slave/test/gaia/profile/webapps/keyboard.gaiamobile.org/application.zip: expected [ Array(56) ] to deeply equal [ Array(54) ]

TEST-UNEXPECTED-FAIL | apps/keyboard/test/build/integration/keyboard_test.js | Keyboard layouts building tests APP=keyboard GAIA_KEYBOARD_LAYOUTS=noPreloadDictRequired GAIA_KEYBOARD_PRELOAD_DICT_LAYOUTS="" make
AssertionError: Checking js/settings/dictionaries.json in /builds/slave/test/gaia/profile/webapps/keyboard.gaiamobile.org/application.zip: expected [ Array(52) ] to deeply equal [ Array(50) ]

This bug deals with fixing the failures.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (PR @ GitHub)

Turns out that the addition of `en-Africa`, `wo`, and `th` layouts broke the tests. We need to fix some json data that the test script expects.

Tim, please check this out or see if you want to re-delegate this to Rudy, thanks!

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Oops... mis-pressed mid-air collision button

Comment 3

[John Lu [:mnjul][Please NI or I'll miss]]

Hi George,

As per offline discussion we'll land this patch first. I'm still waiting for retriggers of Gij-10. However I'm already seeing other Gb failures popping up -- please see https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=37c94590b275 -- I'd like to make sure that those failures are what you talked about just a few moments ago, and that I'm still greenlighted to land my patch.

Thanks a lot for your assistance!

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Those failures are mostly intermittent failures of Gb and they should not be related to your keyboard app's build test. I just land bug 1119731 which will turn Gb to red and then we can file bugs to trace them.

Feel free to file bug on build component!

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Thanks George!

Retriggers are green and the patch has landed on master: https://github.com/mozilla-b2g/gaia/commit/d4b4bb70cef719b39fea8d9d618d2f9a8c11e647

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Oops, forgot to change bug status.