Add information about the front-end unit tests and ui-showcase to Loop's README.txt

RESOLVED FIXED in mozilla38

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla38
Points:
1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This is a partial stopgap whilst we sort out our documentation - add more information to README.txt about the front-end unit tests and the ui-showcase.

I know not everyone reads readmes but for now, at least, it gives us a place to add basic information.
(Assignee)

Comment 1

4 years ago
Created attachment 8554472 [details] [diff] [review]
Add information about the front-end unit tests and ui-showcase to Loop's README.txt.
Attachment #8554472 - Flags: review?(nperriault)
(Assignee)

Updated

4 years ago
Iteration: --- → 38.1 - 26 Jan
Points: --- → 1
Comment on attachment 8554472 [details] [diff] [review]
Add information about the front-end unit tests and ui-showcase to Loop's README.txt.

Review of attachment 8554472 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM with comments addressed.

::: browser/components/loop/README.txt
@@ +24,5 @@
> +Once installed, run build-jsx with the --watch option from
> +browser/components/loop, eg.:
> +
> +    cd browser/components/loop
> +    ./build-jsx --watch

Would be great to have instructions for Windows users as well. Maybe in a part two or with a new dedicated bug.

@@ +69,5 @@
>  
>  
> +UI-Showcase
> +===========
> +This is a tool giving the layouts for all the frontend views of Loop, allowing debugging and testing of css layouts.

Nit: +and local component behavior.
Attachment #8554472 - Flags: review?(nperriault) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Nicolas Perriault (:NiKo`) — needinfo me if you need my attention from comment #2)
> ::: browser/components/loop/README.txt
> @@ +24,5 @@
> > +Once installed, run build-jsx with the --watch option from
> > +browser/components/loop, eg.:
> > +
> > +    cd browser/components/loop
> > +    ./build-jsx --watch
> 
> Would be great to have instructions for Windows users as well. Maybe in a
> part two or with a new dedicated bug.

I think we should wrap it up in bug 1108088 - I'm trying to get my windows vm up to date at the moment so that I can play around and see what's really going on there.

> > +UI-Showcase
> > +===========
> > +This is a tool giving the layouts for all the frontend views of Loop, allowing debugging and testing of css layouts.
> 
> Nit: +and local component behavior.

Fixed.
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/0f87f9d002c1
Target Milestone: --- → mozilla38

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/0f87f9d002c1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.