112580 - Button fixed color elements unreadable in Classic theme on Win32

Status: RESOLVED EXPIRED

(SeaMonkey :: Themes, defect)

Description

[Michal 'hramrach' Suchanek]

To reproduce:

1) set Mozilla skin to classic
2) use Widows color settings that use dark color for button face
ie Yellow on DarkGreen
3) restart Mozilla

- rollover button text is blue
- scrollbar button face is black
- tree twisties are B on W
- pressed button text is red
- MailNews links in table are blue
- menu checks are black
- radio checks are black
- radio gray checks are gray
- links in mail headers are blue

these colors seem not to change with Windows system colors and thus can be
unreadable on DarkGreen this or in other setups.

Comment 1

[Joe Hewitt (gone)]

These colors are hardcoded because there are no available system colors for
them.  There is no way to fix this.  If you choosy wacky system colors you pay
the price.

Comment 2

[Michal 'hramrach' Suchanek]

Dont agree. These colors are completely legal choice and aside from some poorly
designed UI elements everything renders fine. If you intend to support
integration into system, you should cope with color changes. Choosing button
face either very dark or blue may make some text in Mozilla completely
invisible. Note that standard M$ UI elements render fine. Havent noticed any
problem anywhere.

sorry, thre's a typo in the previous comment - I meant button graphics is black
and dont know what MailNews table should have been
 
I think there are some possibilities
a) make things configurable where no system color exists
b) use system colors where possible
ie menu arrows=menu checks=radio checks=checkbox checks=button graphics=*button
text*
    radio gray=checkbox gray=*gray text*

    rollover and pressed colors arent all that important. But if they may render
element unreadable do we need them at all? The buttons get raised/lowered anyway

    for tree twisties see explorer - they are generally the same color as
something else and arent really that important as they are always B on W

    links in mail headers *ARE* importatnt because sender address is dispalyed
as link. This should not be invisible just because your system colors arent what
skin author expected. It is possible to use link color here, but this would
break things in other setup.
A configurable color or only underlining the link seems better. I would suggest
to just underline by default so that people who install Mozilla do not wonder
where sender addresses are.

Comment 3

[Daniel Wang]

*** Bug 146540 has been marked as a duplicate of this bug. ***

Comment 4

[[e-mail]]

Some of these are bug 31726. The links can (in theory) now be coloured with user
preference colours (IIRC this was fixed for editor to use).

Comment 5

[Michal 'hramrach' Suchanek]

Yes, you probably need some sort of bitmap tinting to fix this.

Comment 6

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 7

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420