1125801 - [Costcontrol] Javascript error on startup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marina Rodríguez [:mai]]

STR: 
1. Launch Usage App
2. Look at logcat

Expected: No errors:
Actual:
  W/Usage   ( 7415): [JavaScript Error: "TypeError: handlerContainer.contentWindow.setNextReset is not a function" {file: "app://costcontrol.gaiamobile.org/js/common.js" line: 15}]

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Hi Salva,
would you mind reviewing the patch? 
The bug is produced because when the airplanemode_helper module is loaded, emit a state change event with the current state of the airplanemode. This event produces a second startup of the app.

Regards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8554516 [details] [review]
patch v1.0

Please, if the extra event is launched by the airplane helper, try to find the bug for this problem or file a new one and reference it in a comment in the solution. Try to clarify the variable name to point out you are ignoring this "extra" event.

Thank you.

Comment 3

[Marina Rodríguez [:mai]]

Comment on attachment 8554516 [details] [review]
patch v1.0

Hi Salva,
I've updated the pr with other approach to resolve the bug, would you mind reviewing the patch?
Regards

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8554516 [details] [review]
patch v1.0

It's ok. Thank you for the fix!

Comment 6

[Marina Rodríguez [:mai]]

Master: 030218825c246645ceb0d149274020ef05b443e8