1125828 - [FF Nightly] Sign in button is displayed even if user is logged in Dev Hub

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Victor Carciu]

Prerequisites:
Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0

Steps to reproduce:
1.Go to MP Stage dev-hub and press Sign In button
2.Enter valid credentials on FxA screen and press Sign In

Expected results:
Settings icon is displayed instead of Register and Sign In buttons

Actual results:
Settings icon is not displayed and Register\Sign In are still visible

Please see screencast for this bug : http://screencast.com/t/st0Gjjox9Gu

NOTES:
Reproducible also on -dev
After a refresh, the Settings icon is correctly displayed

Comment 1

[Stuart Colville [:muffinresearch]]

Can you check if you see anything in the logs that indicates an error.

For me I see the page refresh after login which is what updates the UI to show you're signed in. It does take a little bit of time though.

Comment 2

[Victor Carciu]

I am not able to see any error in the console. The button is still Sign in after one minute. Please try to reproduce this on FF Nightly because I just observed that everything works on FF release .

Comment 3

[Stuart Colville [:muffinresearch]]

Works for me in nightly on OSX. Can you see if anyone else can repro with the same OS/browser version?

Comment 4

[Madalin Cotetiu]

I am able to reproduce this issue in FF38(Win7) in marketplace-dev.allizom.orv/developers
Screencast: http://screencast.com/t/hRB4X7dcgpR

Comment 5

[Stuart Colville [:muffinresearch]]

I can repro now too. I think there's an error in the popup maybe - going to see if I can get some logs to find out what's going wrong.

Comment 6

[Stuart Colville [:muffinresearch]]

So digging into this via -dev, I'm not seeing any errors in the console (neither in the page or popup). However I'm noting that at the end of the login flow there's a POST to /api/v1/account/fxa-login/

This is returning a 201. However for nightly (FF 38) the JSON response is garbled whereas on FF 37 the JSON response is good and is followed by the page refresh which updates the UI to show the user is signed in.

I suspect that the broken JSON is causing the login flow to be a dead-end. This needs further investigation but looks likely to be a platform issue that's come in with 38.

Comment 7

[Stuart Colville [:muffinresearch]]

Note the garbled response is generating a SyntaxError in the Response tab of the network dev tools: JSON.parse unexpected character at line 1 column 1 of the JSON data.

Comment 8

[Stuart Colville [:muffinresearch]]

After Andy said he was getting JSON that looked OK I checked charles' for the JSON output and it looks fine. The garbled JSON is probably unrelated.

Using proxying I found this code https://github.com/mozilla/zamboni/blob/master/media/js/devreg/login.js#L155 is being hit.

The window.location.reload is doing nothing to reload the page.

Changing this to window.location = window.location seems to work. I also tried window.location.reload(true) and that didn't work.

Comment 9

[Stuart Colville [:muffinresearch]]

Testing further in nightly it seems that the reload works in other scenarios. It feels like the no-op reload might be related to it happening following the XHR POST.

Going to file a platform bug and see what information we can find as to whether this is a regression or expected behaviour.

Comment 10

[Stuart Colville [:muffinresearch]]

Fixed as of 38.0a1 (2015-02-08)

Comment 11

[Victor Carciu]

Verified as fixed : http://screencast.com/t/ZsHSs6ixom