Closed Bug 1125864 Opened 9 years ago Closed 9 years ago

Revamp our navigation system to support going back

Categories

(support.mozilla.org :: BuddyUp, defect)

Product:
support.mozilla.org
Component:
BuddyUp
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rik, Assigned: rik)

References

Details

(Whiteboard: [blocker])

Attachments

(1 file)

https://github.com/mozilla/buddyup/pull/73
42 bytes, text/x-github-pull-request
rehandalal+mozilla
: review+
Details | Review 
We should keep around the iframes of all pages. 

I'm thinking of a system where we would store a stack of iframes and transition-style. That way, when we go back, we can apply the opposite transition.
Whiteboard: [blocker]
Assignee: nobody → anthony
Status: NEW → ASSIGNED

        Attachment #8557983 -
        Flags: review?(rdalal)

    
    

    
  
Comment on attachment 8557983 [details] [review]
https://github.com/mozilla/buddyup/pull/73

works as expected and the bulk of the code looks fine, but had a couple of nits.

        Attachment #8557983 -
        Flags: review?(rdalal) → review-

    
  

        Attachment #8557983 -
        Flags: review- → review?(rdalal)

        Attachment #8557983 -
        Flags: review?(rdalal) → review+

    
    

    
  
https://github.com/mozilla/buddyup/commit/4525254f411b191eb317df90966f6932d8b46033
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
  
Depends on: 1132905

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: