1125890 - Allow some users to specify an <updateURL> in their install.rdf

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Wil Clouser [:clouserw]]

Authors with unlisted add-ons should be able to specify updateURLs when they upload their add-ons to AMO.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/493

Comment 2

[Mathieu Agopian [:magopian]]

What has been implemented:

The "list this add-on on AMO" checkbox has been moved above the "select a file" button (see the PR for a screenshot), and is now used to know how to call the validator. If it's unchecked, then the validator is called with "listed=False", making it validate the addon as self-hosted (and thus won't fail on the presence of the updateURL in the install.rdf).

If one uploads the file, and then change the checkbox, it'll need a reupload of the file to force a new call to the validator, with the updated "listed" parameter.

Comment 3

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/9e170121404428c38f91eb05b673464f74816cc5

STR:
1/ create an addon with a "<updateURL>" tag in the install.rdf file
2/ try submitting it as a listed addon (leave the "Yes, include my add-on on AMO" checked)
3/ validate that there's a validation error about the updateURL being present
4/ try submitting it as an unlisted addon (uncheck the "Yes, include my add-on on AMO" checkbox)
5/ validate that there's no such validation error, and that the addon can be properly submitted

Comment 4

[Victor Carciu]

Verified as fixed : http://screencast.com/t/fOmPdtwjaXm