If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Use GraphicBuffer::lockAsync() on gonk LL

RESOLVED FIXED in mozilla38

Status

()

Core
Graphics: Layers
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

Trunk
mozilla38
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Since gonk LL, GraphicBuffer::lockAsync() is supported. It is better to use it to minimize the GraphicBuffer lock wait. But it require GRALLOC_MODULE_API_VERSION_0_3. Otherwise, the lock is done synchronously.

http://androidxref.com/5.0.0_r2/xref/frameworks/native/libs/ui/GraphicBuffer.cpp#212
(Assignee)

Updated

3 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

3 years ago
Created attachment 8555294 [details] [diff] [review]
patch - Use GraphicBuffer::lockAsync() on gonk LL
(Assignee)

Updated

3 years ago
Attachment #8555294 - Flags: review?(nical.bugzilla)
(Assignee)

Comment 2

3 years ago
(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> Since gonk LL, GraphicBuffer::lockAsync() is supported. It is better to use
> it to minimize the GraphicBuffer lock wait. But it require
> GRALLOC_MODULE_API_VERSION_0_3. Otherwise, the lock is done synchronously.

By the way, nexus-5's gralloc hal version is 2. Therefore async lock capability is not used.

Updated

3 years ago
Attachment #8555294 - Flags: review?(nical.bugzilla) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8339212a52e
https://hg.mozilla.org/mozilla-central/rev/a8339212a52e
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.