support win64 partner repacks

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
As things stand right now we won't get any 64-bit partner builds (just like Linux, where we only get 32-bit ones). We should figure if and what we want for them in advance of release.

Mike, this isn't urgent just cc'ing you so I don't forget...
I'm going to assert that "yes, we want them" is the correct answer.  Let's figure out how that'll work.
(Assignee)

Comment 2

3 years ago
Created attachment 8554787 [details] [diff] [review]
wip patch

This looks like it will work...needs testing though.
1. yandex.ru has ':win64', should that be just 'win64' or is ':' a wanted comment?

2. partner-repacks.py:174, that ('win64' in platform or 'win64' in platform) looks dubious... search&replace oversight?

3. This will most likely need to be rebased on top of Bug 1124247.
(Assignee)

Comment 4

3 years ago
(In reply to Johannes Pfrang [:johnp] from comment #3)
> 1. yandex.ru has ':win64', should that be just 'win64' or is ':' a wanted
> comment?
> 
> 2. partner-repacks.py:174, that ('win64' in platform or 'win64' in platform)
> looks dubious... search&replace oversight?

Probably. This was just a quick first pass. I'm not surprised there's a couple of errors :).

> 3. This will most likely need to be rebased on top of Bug 1124247.

Funnelcakes are one-offs, and those are being pointed at the release channel anyways.
(Assignee)

Comment 5

3 years ago
Created attachment 8560469 [details] [diff] [review]
tested patch for partner repacks

This is the patch we tested in staging. The win64 partner repacks didn't fully finish there due to bug 1130380, but they got far enough along to verify this bug.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8560469 - Flags: review?(rail)
(Assignee)

Updated

3 years ago
Attachment #8554787 - Attachment is obsolete: true
Comment on attachment 8560469 [details] [diff] [review]
tested patch for partner repacks

Review of attachment 8560469 [details] [diff] [review]:
-----------------------------------------------------------------

conditional r+, do not touch .hgtags! :)
Attachment #8560469 - Flags: review?(rail) → review+
(Assignee)

Updated

3 years ago
Summary: figure our what we want to do for win64 partner builds → support win64 partner repacks
(Assignee)

Updated

3 years ago
Attachment #8560469 - Flags: checked-in+
(Assignee)

Comment 7

3 years ago
Nothing else to do here AFAICT.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.