1126012 - Failing demo-keyboard unit tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Kevin Grandon :kgrandon]

1) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Non-Capital input should give non-capital output:
     Uncaught Error: Error: expected 'fit' to equal 'cite' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  

  2) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Capitalization and suggestions balds:
     Uncaught Error: Error: expected undefined to equal 'baldachin' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  

  3) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Capitalization and suggestions as:
     Uncaught Error: Error: expected 'ask' to equal 'ad' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  

  4) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Capitalization and suggestions As:
     Uncaught Error: Error: expected 'Ask' to equal 'Ad' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  

  5) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Low frequency dictionary words with better suggestion wont:
     Uncaught Error: Error: expected 'winter' to equal 'went' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  

  6) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Words not in a nearby leaf ob / on:
     Uncaught Error: Error: expected 'obi' to equal 'on' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  

  7) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Words not in a nearby leaf hllland / Holland:
     Uncaught Error: Error: expected 'hollandaise' to equal 'Holland' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  

  8) [demo-keyboard-test/unit/worker_test.js] Latin en_us worker Predicitions Words not in a nearby leaf dis / did:
     Uncaught Error: Error: expected 'disc' to equal 'did' (app://demo-keyboard.gaiamobile.org/common/test/helper.js?time=1422309095837:32)
      at onerror (app://demo-keyboard.gaiamobile.org/common/vendor/mocha/mocha.js:4959:10)
  
https://taskcluster-artifacts.s3-us-west-2.amazonaws.com/jrdogYyGTeCtH8wVrthBOg/4/public/logs/live_backing.log?AWSAccessKeyId=AKIAIZOQG4W6WG3PH3RQ&Expires=1422310188&Signature=%2F3b96m%2BkWLzyeFNkGAHsMOvPNiE%3D

Comment 1

[Kevin Grandon :kgrandon]

Jan, Rudy - could one of you guys please help me get this test fixed? It appears to fail on taskcluster, and when running it isolated locally. Thanks!

Comment 2

[Kevin Grandon :kgrandon]

Disabling for now to get taskcluster green: https://github.com/mozilla-b2g/gaia/commit/6ed0df518a9abf240ba9cb65a34f511626beb053

We'll need to revert/undo this when fixing the tests.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This was a pending work for keyboard refactoring, but we did not continue to work on this, and moved back to refactor the original keyboard code instead.
That is to say, we probably would not spend time to fix the test code here.

Comment 4

[Jan Jongboom [:janjongboom] (inactive)]

Attachment: Patch

How about we remove demo-keyboard?

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8555812 [details] [review]
Patch

Let's ask David's opinion on this, since he is the original author of this work.
Thanks.

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8555812 [details] [review]
Patch

I'm still fond of this codebase, but removing it is the right thing to do.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Bunch of tests failing, probably unrelated.

Rebased, let's see if try is green now https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=3e6d0d930846

Comment 8

[Jan Jongboom [:janjongboom] (inactive)]

Tests fail on same error message as bug 1121274...

Comment 9

[Jan Jongboom [:janjongboom] (inactive)]

Hmm, was a permared apparently. Let's try it against todays master. https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=4fe822bf1264

Comment 10

[Jan Jongboom [:janjongboom] (inactive)]

Try is green https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=4fe822bf1264

Landed https://github.com/mozilla-b2g/gaia/commit/87ab7603e88448b97164ba3fb6cd9d3672af732a

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

We were seeing similar test failures on v2.2, so I uplifted a=test-only.

v2.2: https://github.com/mozilla-b2g/gaia/commit/af7173c2f7fe46bf6cd70a5e296bd8cbe48ffc0a

Comment 12

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.