Closed
Bug 1126025
Opened 10 years ago
Closed 10 years ago
Reenable or remove tests disabled in new search behaviour
Categories
(Firefox OS Graveyard :: Gaia::Search, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.2 S5 (6feb)
People
(Reporter: daleharvey, Assigned: daleharvey)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
No description provided.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → dale
|
|
Assignee | |
Comment 1•10 years ago
|
||
These are testing functionality removed with e.me on master, the other will be reenabled with https://bugzilla.mozilla.org/show_bug.cgi?id=1117972 (changed to match new functionality)
Attachment #8557656 -
Flags: review?(bfrancis)
|
|
Assignee | |
Comment 2•10 years ago
|
||
The tests are very red, but this obviously doesnt cause any failures, can review without the test results and will be making sure green before landing
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8557656 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/27834
This is fine, but out of curiosity why don't these tests get removed at the same time as the functionality gets removed?
Attachment #8557656 -
Flags: review?(bfrancis) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
I misread some of the tests and assumed they could be reused with the new suggestions, but it doesnt actually make sense to
|
|
Assignee | |
Comment 5•10 years ago
|
||
Green @ https://treeherder.mozilla.org/#/jobs?repo=gaia-try&revision=ddaf1b37cb61, merged in https://github.com/mozilla-b2g/gaia/commit/b788545f3c5bcffa6e38e9a39b548cf609409f7e, thanks
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S5 (6feb)
You need to log in
before you can comment on or make changes to this bug.
Description
•