Closed Bug 1126080 Opened 9 years ago Closed 9 years ago

Intermittent test_music_change_rating.py TestSetMusicRating.test_music_change_rating | TimeoutException: TimeoutException: Timed out after 10.1 seconds

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KWierso, Assigned: martijn.martijn)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files, 1 obsolete file)

[PullReq] mwargers:test_music to mozilla-b2g:master
46 bytes, text/x-github-pull-request
njpark
: review+
jlorenzo
: review+
Details | Review
[gaia] npark-mozilla:1126080 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
martijn.martijn
: review+
Details | Review 
15:15:27 INFO - TEST-PASS | test_lockscreen_notification.py TestLockScreen.test_lock_screen_notification | took 19958ms
15:15:27 INFO - TEST-START | test_sms_contact_match.py TestContactMatch.test_contact_match
15:15:59 INFO - TEST-PASS | test_sms_contact_match.py TestContactMatch.test_contact_match | took 32526ms
15:15:59 INFO - TEST-START | test_sms_semicolon_completes_the_entered_recipient.py TestSMSContactInput.test_sms_semicolon_completes_the_entered_recipient
15:16:30 INFO - TEST-PASS | test_sms_semicolon_completes_the_entered_recipient.py TestSMSContactInput.test_sms_semicolon_completes_the_entered_recipient | took 30480ms
15:16:30 INFO - TEST-START | test_music_change_rating.py TestSetMusicRating.test_music_change_rating
15:17:02 ERROR - TEST-UNEXPECTED-ERROR | test_music_change_rating.py TestSetMusicRating.test_music_change_rating | TimeoutException: TimeoutException: Timed out after 10.1 seconds
15:17:02 INFO - Traceback (most recent call last):
15:17:02 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 289, in run
15:17:02 INFO - testMethod()
15:17:02 INFO - File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/music/test_music_change_rating.py", line 33, in test_music_change_rating
15:17:02 INFO - list_view = music_app.tap_songs_tab()
15:17:02 INFO - File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/apps/music/app.py", line 63, in tap_songs_tab
15:17:02 INFO - return ListView(self.marionette)
15:17:02 INFO - File "/builds/slave/test/gaia/tests/python/gaia-ui-tests/gaiatest/apps/music/regions/list_view.py", line 28, in __init__
15:17:02 INFO - lambda m: self.marionette.find_element(*self._view_locator).get_attribute('class') == 'scrolling')
15:17:02 INFO - File "/builds/slave/test/build/venv/local/lib/python2.7/site-packages/marionette/wait.py", line 143, in until
15:17:02 INFO - cause=last_exc)
15:17:02 INFO - TEST-INFO took 32237ms
15:17:02 INFO - TEST-START | test_settings_gps.py TestSettingsGPS.test_enable_gps_via_settings_app
15:17:24 INFO - TEST-PASS | test_settings_gps.py TestSettingsGPS.test_enable_gps_via_settings_app | took 21338ms
15:17:24 INFO - TEST-START | test_settings_wallpaper.py TestWallpaper.test_change_wallpaper
I'm seeing this intermittent failure too, while wring a gaia-ui test.
No-Jun, I think you've written this piece of code.
tap_songs_tab is returning ListView: http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/apps/music/regions/list_view.py#27

I'm wondering why those Waits() calls are there.
They seem to be happening when scrollstart and scrollend events are called: http://mxr.mozilla.org/gaia/source/apps/music/js/music.js#52
Flags: needinfo?(npark)
Hmm, that wait was added after I submitted the test, here:
https://github.com/mozilla-b2g/gaia/commit/93d466c4efceee62a844bbbac7374268e846252a#diff-ab14d7eaed0110f5dd46ef3a5d270f86

In order to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1119278.

I think Robert would know the reasons behind the wait() calls.  I will try to update the test_music_change_rating.py script if this is how the list_view should be handled with 3.0 build.  There is a possibility that this could point to a real bug though.
Flags: needinfo?(npark)
Forgot to needinfo Robert regarding the wait statements (Comment 12)
Flags: needinfo?(robert.chira)
As far as I remember those waits were added because the test would asserts some statements while the UI was transitioning between tabs. This was done in Bug 1119278.

I am not sure what changed in the meantime, but if the waits() need to be updated or removed I am ok with that.
Flags: needinfo?(robert.chira) → needinfo?(npark)
I think regarding the start up animation, a number of changes are being made recently, so it's possible the behavior is changed since the code was checked in.  How about we comment out the first Wait statement and see how it goes?  Martijn, what do you think?
Flags: needinfo?(npark) → needinfo?(martijn.martijn)
Ok, I added this pull request, try results here: https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=d47429e3b6ac
Locally, it passes for me with the test 21 times.
Flags: needinfo?(martijn.martijn)
Assignee: nobody → martijn.martijn
Comment on attachment 8561637 [details] [review]
[PullReq] mwargers:test_music to mozilla-b2g:master

Retriggered the tryserver a whole bunch of times.
Attachment #8561637 - Flags: review?(npark)
Comment on attachment 8561637 [details] [review]
[PullReq] mwargers:test_music to mozilla-b2g:master

I think this fix should work (and it does consistently on try server)
Attachment #8561637 - Flags: review?(npark) → review+
Attachment #8561637 - Flags: review?(jlorenzo)
Comment on attachment 8561637 [details] [review]
[PullReq] mwargers:test_music to mozilla-b2g:master

Not a single failure after 71 tries. Given the frequency of the failure, this fix looks like the right one to me.
Attachment #8561637 - Flags: review?(jlorenzo) → review+
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Merged in master at: https://github.com/mozilla-b2g/gaia/commit/9f8d5e7aff99f52fba455a4ce0580f3112b5f37f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Reopened due to new failure.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8571395 - Flags: review?(martijn.martijn)
Attachment #8571395 - Flags: review?(martijn.martijn) → review+
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Component: Gaia::Music → Gaia::UI Tests
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Apparently still happening on b2g_macosx64.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
cannot seem to locally reproduce the result in osx sim environment. will monitor the status for a couple more days, and see whether we should disable the tests in osx ifit does not repro in linux environment.
Attachment #8572147 - Attachment is obsolete: true
Perhaps it was still fixed? Because this intermittent failure hasn't been happening for a while.
Blocks: 1166631
This failure hasn't been showing up for 3 months now, I think we can call this fixed. I guess that last pull request did fix the intermittent failure after all.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: